From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59886) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c4JWG-0006fJ-RZ for qemu-devel@nongnu.org; Tue, 08 Nov 2016 22:25:49 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c4JWB-0007ZI-Uy for qemu-devel@nongnu.org; Tue, 08 Nov 2016 22:25:48 -0500 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:41861) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1c4JWB-0007Z3-Mi for qemu-devel@nongnu.org; Tue, 08 Nov 2016 22:25:43 -0500 Received: from pps.filterd (m0098409.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.17/8.16.0.17) with SMTP id uA93No7S109095 for ; Tue, 8 Nov 2016 22:25:42 -0500 Received: from e35.co.us.ibm.com (e35.co.us.ibm.com [32.97.110.153]) by mx0a-001b2d01.pphosted.com with ESMTP id 26ktdmx5us-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Tue, 08 Nov 2016 22:25:42 -0500 Received: from localhost by e35.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 8 Nov 2016 20:25:41 -0700 Date: Wed, 9 Nov 2016 11:25:34 +0800 From: Dong Jia Shi References: <1478293856-8191-1-git-send-email-kwankhede@nvidia.com> <1478293856-8191-3-git-send-email-kwankhede@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1478293856-8191-3-git-send-email-kwankhede@nvidia.com> Message-Id: <20161109032534.GB4716@bjsdjshi@linux.vnet.ibm.com> Subject: Re: [Qemu-devel] [PATCH v11 02/22] vfio: VFIO based driver for Mediated devices List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kirti Wankhede Cc: alex.williamson@redhat.com, pbonzini@redhat.com, kraxel@redhat.com, cjia@nvidia.com, qemu-devel@nongnu.org, kvm@vger.kernel.org, kevin.tian@intel.com, jike.song@intel.com, bjsdjshi@linux.vnet.ibm.com, linux-kernel@vger.kernel.org * Kirti Wankhede [2016-11-05 02:40:36 +0530]: Hi Kirti, > vfio_mdev driver registers with mdev core driver. > mdev core driver creates mediated device and calls probe routine of > vfio_mdev driver for each device. > Probe routine of vfio_mdev driver adds mediated device to VFIO core module > > This driver forms a shim layer that pass through VFIO devices operations > to vendor driver for mediated devices. > > Signed-off-by: Kirti Wankhede > Signed-off-by: Neo Jia > Change-Id: I583f4734752971d3d112324d69e2508c88f359ec > --- > drivers/vfio/mdev/Kconfig | 9 ++- > drivers/vfio/mdev/Makefile | 1 + > drivers/vfio/mdev/vfio_mdev.c | 148 ++++++++++++++++++++++++++++++++++++++++++ > 3 files changed, 157 insertions(+), 1 deletion(-) > create mode 100644 drivers/vfio/mdev/vfio_mdev.c > > diff --git a/drivers/vfio/mdev/Kconfig b/drivers/vfio/mdev/Kconfig > index 303c14ce2847..79c9cface7b1 100644 > --- a/drivers/vfio/mdev/Kconfig > +++ b/drivers/vfio/mdev/Kconfig > @@ -5,6 +5,13 @@ config VFIO_MDEV > default n > help > Provides a framework to virtualize devices. > - See Documentation/vfio-mdev/vfio-mediated-device.txt for more details. > + See Documentation/vfio-mediated-device.txt for more details. So patch #01 has a wrong doc path. > > If you don't know what do here, say N. > + > +config VFIO_MDEV_DEVICE > + tristate "VFIO support for Mediated devices" > + depends on VFIO && VFIO_MDEV > + default n > + help > + VFIO based driver for mediated devices. I just think the names of the config entries here are a bit strange, but I'm not sure if there is a better way. Maybe (?): s/VFIO_MDEV/VFIO_MDEV_SUPPORT/ s/VFIO_MDEV_DEVICE/VFIO_MDEV/ > diff --git a/drivers/vfio/mdev/Makefile b/drivers/vfio/mdev/Makefile > index 31bc04801d94..fa2d5ea466ee 100644 > --- a/drivers/vfio/mdev/Makefile > +++ b/drivers/vfio/mdev/Makefile > @@ -2,3 +2,4 @@ > mdev-y := mdev_core.o mdev_sysfs.o mdev_driver.o > > obj-$(CONFIG_VFIO_MDEV) += mdev.o > +obj-$(CONFIG_VFIO_MDEV_DEVICE) += vfio_mdev.o > diff --git a/drivers/vfio/mdev/vfio_mdev.c b/drivers/vfio/mdev/vfio_mdev.c [...] > + > +MODULE_VERSION(DRIVER_VERSION); > +MODULE_LICENSE("GPL"); ? GPL V2 > +MODULE_AUTHOR(DRIVER_AUTHOR); > +MODULE_DESCRIPTION(DRIVER_DESC); > -- > 2.7.0 > -- Dong Jia