From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53071) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c4Pjq-0006Gm-TG for qemu-devel@nongnu.org; Wed, 09 Nov 2016 05:04:16 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c4Pjn-0005Iv-0j for qemu-devel@nongnu.org; Wed, 09 Nov 2016 05:04:14 -0500 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:43911 helo=mx0a-001b2d01.pphosted.com) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1c4Pjm-0005Io-S9 for qemu-devel@nongnu.org; Wed, 09 Nov 2016 05:04:10 -0500 Received: from pps.filterd (m0098417.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.17/8.16.0.17) with SMTP id uA99xflF013737 for ; Wed, 9 Nov 2016 05:04:10 -0500 Received: from e06smtp05.uk.ibm.com (e06smtp05.uk.ibm.com [195.75.94.101]) by mx0a-001b2d01.pphosted.com with ESMTP id 26m03tcxjm-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Wed, 09 Nov 2016 05:04:10 -0500 Received: from localhost by e06smtp05.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 9 Nov 2016 10:04:07 -0000 Received: from b06cxnps4075.portsmouth.uk.ibm.com (d06relay12.portsmouth.uk.ibm.com [9.149.109.197]) by d06dlp03.portsmouth.uk.ibm.com (Postfix) with ESMTP id 2AAE01B08067 for ; Wed, 9 Nov 2016 10:06:16 +0000 (GMT) Received: from d06av03.portsmouth.uk.ibm.com (d06av03.portsmouth.uk.ibm.com [9.149.37.213]) by b06cxnps4075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id uA9A43D714549268 for ; Wed, 9 Nov 2016 10:04:03 GMT Received: from d06av03.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av03.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id uA9A41Tb014552 for ; Wed, 9 Nov 2016 03:04:02 -0700 Date: Wed, 9 Nov 2016 11:04:00 +0100 From: Cornelia Huck In-Reply-To: <20161109095238.GE2870@var.eduroam.u-bordeaux.fr> References: <20161107220741.GL2367@var.home> <20161108123449.0e031320.cornelia.huck@de.ibm.com> <20161108201019.GM2378@var.home> <20161109095859.0be2b487.cornelia.huck@de.ibm.com> <20161109090402.GF2378@var.home> <20161109101236.0c660095.cornelia.huck@de.ibm.com> <20161109092835.GA2499@var.bordeaux.inria.fr> <20161109104028.099af5f6.cornelia.huck@de.ibm.com> <20161109095238.GE2870@var.eduroam.u-bordeaux.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-Id: <20161109110400.118d4750.cornelia.huck@de.ibm.com> Subject: Re: [Qemu-devel] [PATCH] Fix legacy ncurses detection. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Samuel Thibault Cc: Peter Maydell , Michal Suchanek , QEMU Developers , Sergey Smolov On Wed, 9 Nov 2016 10:52:38 +0100 Samuel Thibault wrote: > Hello, > > Cornelia Huck, on Wed 09 Nov 2016 10:40:28 +0100, wrote: > > Still curses=no... log attached. > > Oops, sorry, I misplaced my code, and it somehow worked in my case. > Could you give a try at the attached patch instead? Works for me on SLES, Fedora, Ubuntu. Tested-by: Cornelia Huck Sergey, could you test whether the patch works for you as well? (Inserted for convenience.) commit cc8965eb848f53599895a650a6e062319189be1f Author: Samuel Thibault Date: Tue Nov 8 20:57:27 2016 +0100 Fix cursesw detection On systems which do not provide ncursesw.pc and whose /usr/include/curses.h does not include wide support, we should not only try with no -I, i.e. /usr/include, but also with -I/usr/include/ncursesw. To properly detect for wide support with and without -Werror, we need to check for the presence of e.g. the WACS_DEGREE macro. We also want to stop at the first curses_inc_list configuration which works, and make sure to set IFS to : at each new loop. Signed-off-by: Samuel Thibault diff --git a/configure b/configure index fd6f898..7d2a34e 100755 --- a/configure +++ b/configure @@ -2926,7 +2926,7 @@ if test "$curses" != "no" ; then curses_inc_list="$($pkg_config --cflags ncurses 2>/dev/null):" curses_lib_list="$($pkg_config --libs ncurses 2>/dev/null):-lpdcurses" else - curses_inc_list="$($pkg_config --cflags ncursesw 2>/dev/null):" + curses_inc_list="$($pkg_config --cflags ncursesw 2>/dev/null):-I/usr/include/ncursesw:" curses_lib_list="$($pkg_config --libs ncursesw 2>/dev/null):-lncursesw:-lcursesw" fi curses_found=no @@ -2941,11 +2941,13 @@ int main(void) { resize_term(0, 0); addwstr(L"wide chars\n"); addnwstr(&wch, 1); + add_wch(WACS_DEGREE); return s != 0; } EOF IFS=: for curses_inc in $curses_inc_list; do + IFS=: for curses_lib in $curses_lib_list; do unset IFS if compile_prog "$curses_inc" "$curses_lib" ; then @@ -2955,6 +2957,9 @@ EOF break fi done + if test "$curses_found" = yes ; then + break + fi done unset IFS if test "$curses_found" = "yes" ; then