All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Andi Kleen <andi@firstfloor.org>
Cc: linux-kernel@vger.kernel.org, Andi Kleen <ak@linux.intel.com>,
	adrian.hunter@intel.com
Subject: Re: [PATCH] perf tools pt: Remove obsolete paragraph in intel-pt.c
Date: Wed, 9 Nov 2016 10:14:26 -0300	[thread overview]
Message-ID: <20161109131426.GD12125@kernel.org> (raw)
In-Reply-To: <1478650260-30140-1-git-send-email-andi@firstfloor.org>

Em Tue, Nov 08, 2016 at 04:11:00PM -0800, Andi Kleen escreveu:
> From: Andi Kleen <ak@linux.intel.com>
> 
> Since the unprivileged sched switch event was added in perf,
> PT doesn't need need perf_event_paranoid=-1 anymore for
> per cpu decoding. So remove the obsolete paragraph in
> the documentation.

Thanks for pointing that out, I'll do something slightly different tho,
pointing out that from kernel X.Y.Z, when the unprivileged
PERF_RECORD_SWITCH metadata event was introduced, this is no longer an
issue, having to be considered only on older kernels.

- Arnaldo
 
> Cc: adrian.hunter@intel.com
> Signed-off-by: Andi Kleen <ak@linux.intel.com>
> ---
>  tools/perf/Documentation/intel-pt.txt | 10 ----------
>  1 file changed, 10 deletions(-)
> 
> diff --git a/tools/perf/Documentation/intel-pt.txt b/tools/perf/Documentation/intel-pt.txt
> index c6c8318e38a2..c7f817fd3611 100644
> --- a/tools/perf/Documentation/intel-pt.txt
> +++ b/tools/perf/Documentation/intel-pt.txt
> @@ -550,16 +550,6 @@ Unless /proc/sys/kernel/perf_event_paranoid is set to -1, unprivileged users
>  have memory limits imposed upon them.  That affects what buffer sizes they can
>  have as outlined above.
>  
> -Unless /proc/sys/kernel/perf_event_paranoid is set to -1, unprivileged users are
> -not permitted to use tracepoints which means there is insufficient side-band
> -information to decode Intel PT in per-cpu mode, and potentially workload-only
> -mode too if the workload creates new processes.
> -
> -Note also, that to use tracepoints, read-access to debugfs is required.  So if
> -debugfs is not mounted or the user does not have read-access, it will again not
> -be possible to decode Intel PT in per-cpu mode.
> -
> -
>  sched_switch tracepoint
>  -----------------------
>  
> -- 
> 2.5.5

  reply	other threads:[~2016-11-09 13:14 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-09  0:11 [PATCH] perf tools pt: Remove obsolete paragraph in intel-pt.c Andi Kleen
2016-11-09 13:14 ` Arnaldo Carvalho de Melo [this message]
2016-11-09 13:59   ` Arnaldo Carvalho de Melo
2016-11-09 14:01     ` Adrian Hunter
2016-11-09 14:39       ` Arnaldo Carvalho de Melo
2016-11-09 14:44       ` Arnaldo Carvalho de Melo
2016-11-10  8:11         ` Adrian Hunter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161109131426.GD12125@kernel.org \
    --to=acme@kernel.org \
    --cc=adrian.hunter@intel.com \
    --cc=ak@linux.intel.com \
    --cc=andi@firstfloor.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.