From: Tony Lindgren <tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
To: Ladislav Michl <ladis-6z/3iImG2C8G8FEW9MqTrA@public.gmane.org>
Cc: Bin Liu <b-liu-l0cyMroinI0@public.gmane.org>,
linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] usb: musb: omap2430: use dev_err
Date: Wed, 9 Nov 2016 10:48:25 -0700 [thread overview]
Message-ID: <20161109174825.GX2428@atomide.com> (raw)
In-Reply-To: <20161109140914.GE20859-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
* Ladislav Michl <ladis-6z/3iImG2C8G8FEW9MqTrA@public.gmane.org> [161109 07:09]:
> Replace pr_err with dev_err to print also device name.
>
> Signed-off-by: Ladislav Michl <ladis-6z/3iImG2C8G8FEW9MqTrA@public.gmane.org>
Acked-by: Tony Lindgren <tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
> ---
> drivers/usb/musb/omap2430.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/usb/musb/omap2430.c b/drivers/usb/musb/omap2430.c
> index cc12254..451b372 100644
> --- a/drivers/usb/musb/omap2430.c
> +++ b/drivers/usb/musb/omap2430.c
> @@ -277,12 +277,12 @@ static int omap2430_musb_init(struct musb *musb)
> if (status == -ENXIO)
> return status;
>
> - pr_err("HS USB OTG: no transceiver configured\n");
> + dev_err(dev, "HS USB OTG: no transceiver configured\n");
> return -EPROBE_DEFER;
> }
>
> if (IS_ERR(musb->phy)) {
> - pr_err("HS USB OTG: no PHY configured\n");
> + dev_err(dev, "HS USB OTG: no PHY configured\n");
> return PTR_ERR(musb->phy);
> }
> musb->isr = omap2430_musb_interrupt;
> @@ -301,7 +301,7 @@ static int omap2430_musb_init(struct musb *musb)
>
> musb_writel(musb->mregs, OTG_INTERFSEL, l);
>
> - pr_debug("HS USB OTG: revision 0x%x, sysconfig 0x%02x, "
> + dev_dbg(dev, "HS USB OTG: revision 0x%x, sysconfig 0x%02x, "
> "sysstatus 0x%x, intrfsel 0x%x, simenable 0x%x\n",
> musb_readl(musb->mregs, OTG_REVISION),
> musb_readl(musb->mregs, OTG_SYSCONFIG),
> --
> 2.1.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2016-11-09 17:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-09 14:09 [PATCH] usb: musb: omap2430: use dev_err Ladislav Michl
[not found] ` <20161109140914.GE20859-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2016-11-09 17:48 ` Tony Lindgren [this message]
[not found] ` <20161109174825.GX2428-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
2016-11-15 21:13 ` Bin Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161109174825.GX2428@atomide.com \
--to=tony-4v6ys6ai5vpbdgjk7y7tuq@public.gmane.org \
--cc=b-liu-l0cyMroinI0@public.gmane.org \
--cc=ladis-6z/3iImG2C8G8FEW9MqTrA@public.gmane.org \
--cc=linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.