From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Liping Zhang <zlpnobody@163.com>
Cc: netfilter-devel@vger.kernel.org, Liping Zhang <zlpnobody@gmail.com>
Subject: Re: [PATCH nf-next] netfilter: nf_tables: simplify the basic expressions' init routine
Date: Thu, 10 Nov 2016 00:07:23 +0100 [thread overview]
Message-ID: <20161109230723.GA11511@salvia> (raw)
In-Reply-To: <1478438151-30598-1-git-send-email-zlpnobody@163.com>
On Sun, Nov 06, 2016 at 09:15:51PM +0800, Liping Zhang wrote:
> From: Liping Zhang <zlpnobody@gmail.com>
>
> Some basic expressions are built into nf_tables.ko, such as nft_cmp,
> nft_lookup, nft_range and so on. But these basic expressions' init
> routine is a little ugly, too many goto errX labels, and we forget
> to call nft_range_module_exit in the exit routine, although it is
> harmless.
>
> Acctually, the init and exit routines of these basic expressions
> are same, i.e. do nft_register_expr in the init routine and do
> nft_unregister_expr in the exit routine.
>
> So it's better to arrange them into an array and deal with them
> together.
Applied, thanks.
prev parent reply other threads:[~2016-11-09 23:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-06 13:15 [PATCH nf-next] netfilter: nf_tables: simplify the basic expressions' init routine Liping Zhang
2016-11-09 23:07 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161109230723.GA11511@salvia \
--to=pablo@netfilter.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=zlpnobody@163.com \
--cc=zlpnobody@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.