From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Eugene Korenevsky <ekorenevsky@gmail.com>,
linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org
Subject: Re: [PATCH v4] USB hub_probe: rework ugly goto-into-compound-statement
Date: Thu, 10 Nov 2016 07:06:44 +0100 [thread overview]
Message-ID: <20161110060644.GA28591@kroah.com> (raw)
In-Reply-To: <20161109153521.GA20272@vnote>
On Wed, Nov 09, 2016 at 06:35:21PM +0300, Eugene Korenevsky wrote:
> Rework smelling code (goto inside compound statement). Perhaps this is
> legacy. Anyway such code is not appropriate for Linux kernel.
>
> Changes since v3: fix typo
> Changes since v2: extract the code to static function
> Changes since v1: fix spaces instead of tab, add missing 'Signed-off-by'
changes go below the --- line, please read
Documentation/SubmittingPatches for all of the details.
thanks,
greg k-h
prev parent reply other threads:[~2016-11-10 11:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-09 15:35 [PATCH v4] USB hub_probe: rework ugly goto-into-compound-statement Eugene Korenevsky
2016-11-10 5:50 ` Baolin Wang
2016-11-10 6:06 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161110060644.GA28591@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=ekorenevsky@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.