From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.linuxfoundation.org ([140.211.169.12]:39086 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755537AbcKJLdY (ORCPT ); Thu, 10 Nov 2016 06:33:24 -0500 Date: Thu, 10 Nov 2016 08:13:27 +0100 From: Greg KH To: Emil Velikov Cc: dri-devel@lists.freedesktop.org, Bjorn Helgaas , linux-pci@vger.kernel.org Subject: Re: [PATCH v2] PCI: create revision file in sysfs Message-ID: <20161110071327.GA30661@kroah.com> References: <20161101154232.6451-1-emil.l.velikov@gmail.com> <20161109165607.26322-1-emil.l.velikov@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <20161109165607.26322-1-emil.l.velikov@gmail.com> Sender: linux-pci-owner@vger.kernel.org List-ID: On Wed, Nov 09, 2016 at 04:56:07PM +0000, Emil Velikov wrote: > From: Emil Velikov > > Currently the revision isn't available via sysfs/libudev thus if one > wants to know the value they need to read through the config file. > > This in itself wakes/powers up the device, causing unwanted delays. > > There are at least two userspace components which could make use the new > file - libpciaccess and libdrm. At the moment the former will wake up > _every_ PCI device for simple invocation of glxinfo [when using Mesa > 10.0+ drivers]. While the latter [in association with Mesa 13.0] can > lead to 2-3 second delays while starting firefox, thunderbird or > chromium. > > Expose the revision as a separate file, just like we do for the device, > vendor, their subsystem version and class. > > Cc: Bjorn Helgaas > Cc: linux-pci@vger.kernel.org > Link: https://bugs.freedesktop.org/show_bug.cgi?id=98502 > Tested-by: Mauro Santos > Reviewed-by: Alex Deucher > Signed-off-by: Emil Velikov > --- > v2: > - Add r-b/t-b tags > - Slim down CC list > - Add note about userspace. > > As before, please keep me in the CC list. Additionally if there's > anything else I can do to get things going please let me know. > > Thanks > Emil > --- > drivers/pci/pci-sysfs.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/pci/pci-sysfs.c b/drivers/pci/pci-sysfs.c > index bcd10c7..0666287 100644 > --- a/drivers/pci/pci-sysfs.c > +++ b/drivers/pci/pci-sysfs.c > @@ -50,6 +50,7 @@ pci_config_attr(vendor, "0x%04x\n"); > pci_config_attr(device, "0x%04x\n"); > pci_config_attr(subsystem_vendor, "0x%04x\n"); > pci_config_attr(subsystem_device, "0x%04x\n"); > +pci_config_attr(revision, "0x%02x\n"); > pci_config_attr(class, "0x%06x\n"); > pci_config_attr(irq, "%u\n"); Shouldn't we get a Documentation/ABI/ update for this as well? thanks, greg k-h From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg KH Subject: Re: [PATCH v2] PCI: create revision file in sysfs Date: Thu, 10 Nov 2016 08:13:27 +0100 Message-ID: <20161110071327.GA30661@kroah.com> References: <20161101154232.6451-1-emil.l.velikov@gmail.com> <20161109165607.26322-1-emil.l.velikov@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail.linuxfoundation.org (mail.linuxfoundation.org [140.211.169.12]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0DCC76E7BA for ; Thu, 10 Nov 2016 11:33:24 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20161109165607.26322-1-emil.l.velikov@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Emil Velikov Cc: Bjorn Helgaas , linux-pci@vger.kernel.org, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org T24gV2VkLCBOb3YgMDksIDIwMTYgYXQgMDQ6NTY6MDdQTSArMDAwMCwgRW1pbCBWZWxpa292IHdy b3RlOgo+IEZyb206IEVtaWwgVmVsaWtvdiA8ZW1pbC52ZWxpa292QGNvbGxhYm9yYS5jb20+Cj4g Cj4gQ3VycmVudGx5IHRoZSByZXZpc2lvbiBpc24ndCBhdmFpbGFibGUgdmlhIHN5c2ZzL2xpYnVk ZXYgdGh1cyBpZiBvbmUKPiB3YW50cyB0byBrbm93IHRoZSB2YWx1ZSB0aGV5IG5lZWQgdG8gcmVh ZCB0aHJvdWdoIHRoZSBjb25maWcgZmlsZS4KPiAKPiBUaGlzIGluIGl0c2VsZiB3YWtlcy9wb3dl cnMgdXAgdGhlIGRldmljZSwgY2F1c2luZyB1bndhbnRlZCBkZWxheXMuCj4gCj4gVGhlcmUgYXJl IGF0IGxlYXN0IHR3byB1c2Vyc3BhY2UgY29tcG9uZW50cyB3aGljaCBjb3VsZCBtYWtlIHVzZSB0 aGUgbmV3Cj4gZmlsZSAtIGxpYnBjaWFjY2VzcyBhbmQgbGliZHJtLiBBdCB0aGUgbW9tZW50IHRo ZSBmb3JtZXIgd2lsbCB3YWtlIHVwCj4gX2V2ZXJ5XyBQQ0kgZGV2aWNlIGZvciBzaW1wbGUgaW52 b2NhdGlvbiBvZiBnbHhpbmZvIFt3aGVuIHVzaW5nIE1lc2EKPiAxMC4wKyBkcml2ZXJzXS4gV2hp bGUgdGhlIGxhdHRlciBbaW4gYXNzb2NpYXRpb24gd2l0aCBNZXNhIDEzLjBdIGNhbgo+IGxlYWQg dG8gMi0zIHNlY29uZCBkZWxheXMgd2hpbGUgc3RhcnRpbmcgZmlyZWZveCwgdGh1bmRlcmJpcmQg b3IKPiBjaHJvbWl1bS4KPiAKPiBFeHBvc2UgdGhlIHJldmlzaW9uIGFzIGEgc2VwYXJhdGUgZmls ZSwganVzdCBsaWtlIHdlIGRvIGZvciB0aGUgZGV2aWNlLAo+IHZlbmRvciwgdGhlaXIgc3Vic3lz dGVtIHZlcnNpb24gYW5kIGNsYXNzLgo+IAo+IENjOiBCam9ybiBIZWxnYWFzIDxiaGVsZ2Fhc0Bn b29nbGUuY29tPgo+IENjOiBsaW51eC1wY2lAdmdlci5rZXJuZWwub3JnCj4gTGluazogaHR0cHM6 Ly9idWdzLmZyZWVkZXNrdG9wLm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTg1MDIKPiBUZXN0ZWQtYnk6 IE1hdXJvIFNhbnRvcyA8cmVnaXN0by5tYWlsbGluZ0BnbWFpbC5jb20+Cj4gUmV2aWV3ZWQtYnk6 IEFsZXggRGV1Y2hlciA8YWxleGFuZGVyLmRldWNoZXJAYW1kLmNvbT4KPiBTaWduZWQtb2ZmLWJ5 OiBFbWlsIFZlbGlrb3YgPGVtaWwudmVsaWtvdkBjb2xsYWJvcmEuY29tPgo+IC0tLQo+IHYyOgo+ ICAtIEFkZCByLWIvdC1iIHRhZ3MKPiAgLSBTbGltIGRvd24gQ0MgbGlzdAo+ICAtIEFkZCBub3Rl IGFib3V0IHVzZXJzcGFjZS4KPiAKPiBBcyBiZWZvcmUsIHBsZWFzZSBrZWVwIG1lIGluIHRoZSBD QyBsaXN0LiBBZGRpdGlvbmFsbHkgaWYgdGhlcmUncwo+IGFueXRoaW5nIGVsc2UgSSBjYW4gZG8g dG8gZ2V0IHRoaW5ncyBnb2luZyBwbGVhc2UgbGV0IG1lIGtub3cuCj4gCj4gVGhhbmtzCj4gRW1p bAo+IC0tLQo+ICBkcml2ZXJzL3BjaS9wY2ktc3lzZnMuYyB8IDIgKysKPiAgMSBmaWxlIGNoYW5n ZWQsIDIgaW5zZXJ0aW9ucygrKQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL3BjaS9wY2ktc3lz ZnMuYyBiL2RyaXZlcnMvcGNpL3BjaS1zeXNmcy5jCj4gaW5kZXggYmNkMTBjNy4uMDY2NjI4NyAx MDA2NDQKPiAtLS0gYS9kcml2ZXJzL3BjaS9wY2ktc3lzZnMuYwo+ICsrKyBiL2RyaXZlcnMvcGNp L3BjaS1zeXNmcy5jCj4gQEAgLTUwLDYgKzUwLDcgQEAgcGNpX2NvbmZpZ19hdHRyKHZlbmRvciwg IjB4JTA0eFxuIik7Cj4gIHBjaV9jb25maWdfYXR0cihkZXZpY2UsICIweCUwNHhcbiIpOwo+ICBw Y2lfY29uZmlnX2F0dHIoc3Vic3lzdGVtX3ZlbmRvciwgIjB4JTA0eFxuIik7Cj4gIHBjaV9jb25m aWdfYXR0cihzdWJzeXN0ZW1fZGV2aWNlLCAiMHglMDR4XG4iKTsKPiArcGNpX2NvbmZpZ19hdHRy KHJldmlzaW9uLCAiMHglMDJ4XG4iKTsKPiAgcGNpX2NvbmZpZ19hdHRyKGNsYXNzLCAiMHglMDZ4 XG4iKTsKPiAgcGNpX2NvbmZpZ19hdHRyKGlycSwgIiV1XG4iKTsKClNob3VsZG4ndCB3ZSBnZXQg YSBEb2N1bWVudGF0aW9uL0FCSS8gdXBkYXRlIGZvciB0aGlzIGFzIHdlbGw/Cgp0aGFua3MsCgpn cmVnIGstaApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpk cmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0 cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK