From: Peter Wu <peter@lekensteyn.nl>
To: Hans de Goede <hdegoede@redhat.com>
Cc: Ben Skeggs <bskeggs@redhat.com>,
"Rafael J . Wysocki" <rjw@rjwysocki.net>,
Zhang Rui <rui.zhang@intel.com>, Len Brown <lenb@kernel.org>,
Dave Airlie <airlied@redhat.com>,
linux-acpi@vger.kernel.org, dri-devel@lists.freedesktop.org,
nouveau@lists.freedesktop.org
Subject: Re: [Nouveau] [PATCH] acpi: video: Move ACPI_VIDEO_NOTIFY_* defines to acpi/video.h
Date: Thu, 10 Nov 2016 11:11:25 +0100 [thread overview]
Message-ID: <20161110101125.GA13197@al> (raw)
In-Reply-To: <20161109171556.4003-1-hdegoede@redhat.com>
On Wed, Nov 09, 2016 at 06:15:56PM +0100, Hans de Goede wrote:
> acpi_video.c passed the ACPI_VIDEO_NOTIFY_* defines as type code to
> acpi_notifier_call_chain(). Move these defines to acpi/video.h so
> that acpi_notifier listeners can check the type code using these
> defines.
>
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Reviewed-by: Peter Wu <peter@lekensteyn.nl>
> ---
> drivers/acpi/acpi_video.c | 11 -----------
> include/acpi/video.h | 11 +++++++++++
> 2 files changed, 11 insertions(+), 11 deletions(-)
>
> diff --git a/drivers/acpi/acpi_video.c b/drivers/acpi/acpi_video.c
> index c5557d0..201292e 100644
> --- a/drivers/acpi/acpi_video.c
> +++ b/drivers/acpi/acpi_video.c
> @@ -43,17 +43,6 @@
>
> #define ACPI_VIDEO_BUS_NAME "Video Bus"
> #define ACPI_VIDEO_DEVICE_NAME "Video Device"
> -#define ACPI_VIDEO_NOTIFY_SWITCH 0x80
> -#define ACPI_VIDEO_NOTIFY_PROBE 0x81
> -#define ACPI_VIDEO_NOTIFY_CYCLE 0x82
> -#define ACPI_VIDEO_NOTIFY_NEXT_OUTPUT 0x83
> -#define ACPI_VIDEO_NOTIFY_PREV_OUTPUT 0x84
> -
> -#define ACPI_VIDEO_NOTIFY_CYCLE_BRIGHTNESS 0x85
> -#define ACPI_VIDEO_NOTIFY_INC_BRIGHTNESS 0x86
> -#define ACPI_VIDEO_NOTIFY_DEC_BRIGHTNESS 0x87
> -#define ACPI_VIDEO_NOTIFY_ZERO_BRIGHTNESS 0x88
> -#define ACPI_VIDEO_NOTIFY_DISPLAY_OFF 0x89
>
> #define MAX_NAME_LEN 20
>
> diff --git a/include/acpi/video.h b/include/acpi/video.h
> index 4536bd3..bfe484d 100644
> --- a/include/acpi/video.h
> +++ b/include/acpi/video.h
> @@ -30,6 +30,17 @@ struct acpi_device;
> #define ACPI_VIDEO_DISPLAY_LEGACY_PANEL 0x0110
> #define ACPI_VIDEO_DISPLAY_LEGACY_TV 0x0200
>
> +#define ACPI_VIDEO_NOTIFY_SWITCH 0x80
> +#define ACPI_VIDEO_NOTIFY_PROBE 0x81
> +#define ACPI_VIDEO_NOTIFY_CYCLE 0x82
> +#define ACPI_VIDEO_NOTIFY_NEXT_OUTPUT 0x83
> +#define ACPI_VIDEO_NOTIFY_PREV_OUTPUT 0x84
> +#define ACPI_VIDEO_NOTIFY_CYCLE_BRIGHTNESS 0x85
> +#define ACPI_VIDEO_NOTIFY_INC_BRIGHTNESS 0x86
> +#define ACPI_VIDEO_NOTIFY_DEC_BRIGHTNESS 0x87
> +#define ACPI_VIDEO_NOTIFY_ZERO_BRIGHTNESS 0x88
> +#define ACPI_VIDEO_NOTIFY_DISPLAY_OFF 0x89
> +
> enum acpi_backlight_type {
> acpi_backlight_undef = -1,
> acpi_backlight_none = 0,
> --
> 2.9.3
>
next prev parent reply other threads:[~2016-11-10 10:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-09 17:15 [PATCH] acpi: video: Move ACPI_VIDEO_NOTIFY_* defines to acpi/video.h Hans de Goede
2016-11-10 10:11 ` Peter Wu [this message]
2016-11-24 1:27 ` Rafael J. Wysocki
2016-11-24 1:30 ` Ben Skeggs
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161110101125.GA13197@al \
--to=peter@lekensteyn.nl \
--cc=airlied@redhat.com \
--cc=bskeggs@redhat.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=hdegoede@redhat.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=nouveau@lists.freedesktop.org \
--cc=rjw@rjwysocki.net \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.