All of lore.kernel.org
 help / color / mirror / Atom feed
From: Joerg Roedel <joro@8bytes.org>
To: David Woodhouse <dwmw2@infradead.org>
Cc: Xunlei Pang <xlpang@redhat.com>,
	iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org,
	Mika Kuoppala <mika.kuoppala@linux.intel.com>
Subject: Re: [PATCH] iommu/vt-d: Fix the size calculation of pasid table
Date: Thu, 10 Nov 2016 11:45:44 +0100	[thread overview]
Message-ID: <20161110104544.GA2078@8bytes.org> (raw)
In-Reply-To: <1477829902.4154.9.camel@infradead.org>

Hi David,

On Sun, Oct 30, 2016 at 06:18:22AM -0600, David Woodhouse wrote:
> +	/* Start at 2 because it's defined as 1^(1+PSS) */

This probably means 2^(1+PSS), right?

> +	iommu->pasid_max = 2 << ecap_pss(iommu->ecap);

Otherwise the patch looks good. Do you want to send it upstream yourself
or should I pick it up?



	Joerg

  parent reply	other threads:[~2016-11-10 10:45 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-12  2:49 [PATCH] iommu/vt-d: Fix the size calculation of pasid table Xunlei Pang
     [not found] ` <1473648551-10025-1-git-send-email-xlpang-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2016-09-19 12:18   ` Joerg Roedel
2016-09-19 12:18     ` Joerg Roedel
     [not found]     ` <20160919121827.GB3541-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
2016-10-10 13:00       ` Xunlei Pang
2016-10-10 13:00         ` Xunlei Pang
2016-10-12 12:17       ` David Woodhouse
2016-10-12 12:17         ` David Woodhouse
     [not found]         ` <1476274674.16627.173.camel-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
2016-10-30 12:18           ` David Woodhouse
2016-10-30 12:18             ` David Woodhouse
2016-10-31 11:30             ` Xunlei Pang
2016-11-10 10:45             ` Joerg Roedel [this message]
     [not found]               ` <20161110104544.GA2078-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
2016-11-10 11:02                 ` David Woodhouse
2016-11-10 11:02                   ` David Woodhouse

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161110104544.GA2078@8bytes.org \
    --to=joro@8bytes.org \
    --cc=dwmw2@infradead.org \
    --cc=iommu@lists.linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mika.kuoppala@linux.intel.com \
    --cc=xlpang@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.