From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35474) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c4mxK-00060v-7o for qemu-devel@nongnu.org; Thu, 10 Nov 2016 05:51:43 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c4mxG-0002O9-Cm for qemu-devel@nongnu.org; Thu, 10 Nov 2016 05:51:42 -0500 Received: from mail-lf0-x243.google.com ([2a00:1450:4010:c07::243]:33334) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1c4mxG-0002Nq-4p for qemu-devel@nongnu.org; Thu, 10 Nov 2016 05:51:38 -0500 Received: by mail-lf0-x243.google.com with SMTP id 98so11738759lfs.0 for ; Thu, 10 Nov 2016 02:51:37 -0800 (PST) Date: Thu, 10 Nov 2016 11:51:34 +0100 From: "Edgar E. Iglesias" Message-ID: <20161110105134.GN9606@toto> References: <1478694124-15803-1-git-send-email-david@gibson.dropbear.id.au> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1478694124-15803-1-git-send-email-david@gibson.dropbear.id.au> Subject: Re: [Qemu-devel] [PATCHv2 0/3] Allow ISA to be disabled on some platforms List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: David Gibson Cc: michael@walle.cc, proljc@gmail.com, borntraeger@de.ibm.com, cornelia.huck@de.ibm.com, kbastian@mail.uni-paderborn.de, jcmvbkbc@gmail.com, agraf@suse.de, mst@redhat.com, armbru@redhat.com, pbonzini@redhat.com, peter.maydell@linaro.org, veroniabahaa@gmail.com, qemu-devel@nongnu.org On Wed, Nov 09, 2016 at 11:22:01PM +1100, David Gibson wrote: > This is a rebase and revision of a series I wrote quite some time ago. > This makes some cleanups that are a start on allowing ISA to be > compiled out for platforms which don't use it. > > Unfortunately, a lot of the pieces here don't have a clear maintainer. > So, I'm hoping to get some Acked-bys from the maintainers of the > affected targets, then I intend to send a pull request direct to Peter. Looks good to me: Reviewed-by: Edgar E. Iglesias Best regards, Edgar > > Notes: > * Patch 3/3 triggers a style warning, but that's just because I'm > moving a C++ // comment verbatim from one file to another > > Changes since v1: > * Fixed some silly compile errors in 3/3 exposed by some > changes in other headers > > David Gibson (3): > Split serial-isa into its own config option > Allow ISA bus to be configured out > Split ISA and sysbus versions of m48t59 device > > default-configs/alpha-softmmu.mak | 1 + > default-configs/arm-softmmu.mak | 1 + > default-configs/i386-softmmu.mak | 1 + > default-configs/mips-softmmu-common.mak | 1 + > default-configs/moxie-softmmu.mak | 2 + > default-configs/pci.mak | 3 + > default-configs/ppc-softmmu.mak | 1 + > default-configs/ppc64-softmmu.mak | 1 + > default-configs/ppcemb-softmmu.mak | 1 + > default-configs/sh4-softmmu.mak | 1 + > default-configs/sh4eb-softmmu.mak | 1 + > default-configs/sparc-softmmu.mak | 1 + > default-configs/sparc64-softmmu.mak | 1 + > default-configs/unicore32-softmmu.mak | 1 + > default-configs/x86_64-softmmu.mak | 1 + > hw/char/Makefile.objs | 3 +- > hw/isa/Makefile.objs | 2 +- > hw/timer/Makefile.objs | 3 + > hw/timer/m48t59-internal.h | 82 ++++++++++++ > hw/timer/m48t59-isa.c | 181 +++++++++++++++++++++++++ > hw/timer/m48t59.c | 228 +++----------------------------- > 21 files changed, 305 insertions(+), 212 deletions(-) > create mode 100644 hw/timer/m48t59-internal.h > create mode 100644 hw/timer/m48t59-isa.c > > -- > 2.7.4 >