diff for duplicates of <20161110111506.02842cbd@free-electrons.com> diff --git a/a/1.txt b/N1/1.txt index d8595f0..7d6b44e 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -3,7 +3,7 @@ Hello, On Thu, 10 Nov 2016 10:36:47 +0100, Gregory CLEMENT wrote: > >> - bootrom { -> >> + bootrom at 0 { +> >> + bootrom@0 { > >> compatible = "marvell,bootrom"; > >> reg = <MBUS_ID(0x01, 0x1d) 0 0x100000>; > > @@ -16,18 +16,18 @@ Which I think is bogus, as my example below highlighted. > > A good example of why I'm worried is the sa-sram case: > > -> > + crypto_sram0: sa-sram0 at 0 { +> > + crypto_sram0: sa-sram0@0 { > > compatible = "mmio-sram"; > > reg = <MBUS_ID(0x09, 0x09) 0 0x800>; > > -> > + crypto_sram1: sa-sram1 at 0 { +> > + crypto_sram1: sa-sram1@0 { > > compatible = "mmio-sram"; > > reg = <MBUS_ID(0x09, 0x05) 0 0x800>; > > > > The node names should be just "sram" without a number. Indeed for UARTs -> > for example, you use uart at XYZ, uart at ABC and not uart0 at XYZ and -> > uart1 at ABC. But then, if you do that, with your scheme, you end up with -> > both nodes named sa-sram at 0. +> > for example, you use uart@XYZ, uart@ABC and not uart0@XYZ and +> > uart1@ABC. But then, if you do that, with your scheme, you end up with +> > both nodes named sa-sram@0. > > > > Which clearly shows that the way you set this unit-address is not > > correct: those two devices are mapped at completely different @@ -40,12 +40,12 @@ Which I think is bogus, as my example below highlighted. > concern. What I propose then is to expose the memory windows ID by > adding the target and the attributes like this: > -> crypto_sram0: sa-sram at 09_09_0 { +> crypto_sram0: sa-sram@09_09_0 { > compatible = "mmio-sram"; > reg = <MBUS_ID(0x09, 0x09) 0 0x800>; > > -> crypto_sram1: sa-sram at 09_05_0 { +> crypto_sram1: sa-sram@09_05_0 { > compatible = "mmio-sram"; > reg = <MBUS_ID(0x09, 0x05) 0 0x800>; @@ -63,3 +63,7 @@ Thomas Thomas Petazzoni, CTO, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com +-- +To unsubscribe from this list: send the line "unsubscribe devicetree" in +the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org +More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/a/content_digest b/N1/content_digest index 865fb40..0a0c5d5 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -2,10 +2,17 @@ "ref\020161110001000.10619-5-gregory.clement@free-electrons.com\0" "ref\020161110092221.0219490b@free-electrons.com\0" "ref\087wpgbekwg.fsf@free-electrons.com\0" - "From\0thomas.petazzoni@free-electrons.com (Thomas Petazzoni)\0" - "Subject\0[PATCH 04/14] ARM: dts: armada-375: Fixup bootrom DT warning\0" + "ref\087wpgbekwg.fsf-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org\0" + "From\0Thomas Petazzoni <thomas.petazzoni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>\0" + "Subject\0Re: [PATCH 04/14] ARM: dts: armada-375: Fixup bootrom DT warning\0" "Date\0Thu, 10 Nov 2016 11:15:06 +0100\0" - "To\0linux-arm-kernel@lists.infradead.org\0" + "To\0Gregory CLEMENT <gregory.clement-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>\0" + "Cc\0Jason Cooper <jason-NLaQJdtUoK4Be96aLqz0jA@public.gmane.org>" + Andrew Lunn <andrew-g2DYL2Zd6BY@public.gmane.org> + Sebastian Hesselbarth <sebastian.hesselbarth-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> + linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org + Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> + " devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org\0" "\00:1\0" "b\0" "Hello,\n" @@ -13,7 +20,7 @@ "On Thu, 10 Nov 2016 10:36:47 +0100, Gregory CLEMENT wrote:\n" "\n" "> >> -\t\tbootrom {\n" - "> >> +\t\tbootrom at 0 {\n" + "> >> +\t\tbootrom@0 {\n" "> >> \t\t\tcompatible = \"marvell,bootrom\";\n" "> >> \t\t\treg = <MBUS_ID(0x01, 0x1d) 0 0x100000>; \n" "> >\n" @@ -26,18 +33,18 @@ "\n" "> > A good example of why I'm worried is the sa-sram case:\n" "> >\n" - "> > +\t\tcrypto_sram0: sa-sram0 at 0 {\n" + "> > +\t\tcrypto_sram0: sa-sram0@0 {\n" "> > \t\t\tcompatible = \"mmio-sram\";\n" "> > \t\t\treg = <MBUS_ID(0x09, 0x09) 0 0x800>;\n" "> >\n" - "> > +\t\tcrypto_sram1: sa-sram1 at 0 {\n" + "> > +\t\tcrypto_sram1: sa-sram1@0 {\n" "> > \t\t\tcompatible = \"mmio-sram\";\n" "> > \t\t\treg = <MBUS_ID(0x09, 0x05) 0 0x800>;\n" "> >\n" "> > The node names should be just \"sram\" without a number. Indeed for UARTs\n" - "> > for example, you use uart at XYZ, uart at ABC and not uart0 at XYZ and\n" - "> > uart1 at ABC. But then, if you do that, with your scheme, you end up with\n" - "> > both nodes named sa-sram at 0.\n" + "> > for example, you use uart@XYZ, uart@ABC and not uart0@XYZ and\n" + "> > uart1@ABC. But then, if you do that, with your scheme, you end up with\n" + "> > both nodes named sa-sram@0.\n" "> >\n" "> > Which clearly shows that the way you set this unit-address is not\n" "> > correct: those two devices are mapped at completely different\n" @@ -50,12 +57,12 @@ "> concern. What I propose then is to expose the memory windows ID by\n" "> adding the target and the attributes like this:\n" "> \n" - "> \t\tcrypto_sram0: sa-sram at 09_09_0 {\n" + "> \t\tcrypto_sram0: sa-sram@09_09_0 {\n" "> \t\t\tcompatible = \"mmio-sram\";\n" "> \t\t\treg = <MBUS_ID(0x09, 0x09) 0 0x800>;\n" "> \n" "> \n" - "> \t\tcrypto_sram1: sa-sram at 09_05_0 {\n" + "> \t\tcrypto_sram1: sa-sram@09_05_0 {\n" "> \t\t\tcompatible = \"mmio-sram\";\n" "> \t\t\treg = <MBUS_ID(0x09, 0x05) 0 0x800>;\n" "\n" @@ -72,6 +79,10 @@ "-- \n" "Thomas Petazzoni, CTO, Free Electrons\n" "Embedded Linux and Kernel engineering\n" - http://free-electrons.com + "http://free-electrons.com\n" + "--\n" + "To unsubscribe from this list: send the line \"unsubscribe devicetree\" in\n" + "the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org\n" + More majordomo info at http://vger.kernel.org/majordomo-info.html -a5aa8169727653bd887869f457626228b5bb8e2afa0ac199666026735c299862 +2a9f0f4084312927902b20bb929513ee0b82c01e1c1380db16202f0f7c260e7d
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.