From: Joerg Roedel <joro@8bytes.org>
To: Baoquan He <bhe@redhat.com>
Cc: iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org,
kexec@lists.infradead.org, Vincent.Wan@amd.com,
dyoung@redhat.com, xlpang@redhat.com
Subject: Re: [PATCH v6 7/9] iommu/amd: Update domain into to dte entry during device driver init
Date: Thu, 10 Nov 2016 12:48:16 +0100 [thread overview]
Message-ID: <20161110114816.GE9996@8bytes.org> (raw)
In-Reply-To: <1476963440-23039-8-git-send-email-bhe@redhat.com>
On Thu, Oct 20, 2016 at 07:37:18PM +0800, Baoquan He wrote:
> prot = dir2prot(direction);
> + if (translation_pre_enabled(iommu) && !dev_data->domain_updated) {
> + dev_data->domain_updated = true;
> + set_dte_entry(dev_data->devid, domain, dev_data->ats.enabled);
> + if (alias != dev_data->devid)
> + set_dte_entry(alias, domain, dev_data->ats.enabled);
> + device_flush_dte(dev_data);
> + }
Hmm, I really don't like to have these checks in the fast-path. But to
get rid of it I think we need to re-work the way domains are assigned to
devices.
One way to do this would be to add a 'defered-domain-attach' feature to
the iommu-core code. What do you think about this?
Joerg
next prev parent reply other threads:[~2016-11-10 11:48 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-20 11:37 [PATCH v6 0/9] Fix kdump faults on system with amd iommu Baoquan He
2016-10-20 11:37 ` Baoquan He
2016-10-20 11:37 ` Baoquan He
2016-10-20 11:37 ` [PATCH v6 1/9] iommu/amd: Detect pre enabled translation Baoquan He
2016-10-20 11:37 ` Baoquan He
2016-10-20 11:37 ` [PATCH v6 2/9] iommu/amd: add several helper function Baoquan He
2016-10-20 11:37 ` Baoquan He
2016-10-20 11:37 ` Baoquan He
2016-10-20 11:37 ` [PATCH v6 3/9] iommu/amd: Define bit fields for DTE particularly Baoquan He
2016-10-20 11:37 ` Baoquan He
2016-10-20 11:37 ` Baoquan He
2016-10-20 11:37 ` [PATCH v6 4/9] iommu/amd: Add function copy_dev_tables Baoquan He
2016-10-20 11:37 ` Baoquan He
2016-10-20 11:37 ` Baoquan He
2016-10-20 11:37 ` [PATCH v6 5/9] iommu/amd: copy old trans table from old kernel Baoquan He
2016-10-20 11:37 ` Baoquan He
2016-10-20 11:37 ` Baoquan He
2016-10-20 11:37 ` [PATCH v6 6/9] iommu/amd: Don't update domain info to dte entry at iommu init stage Baoquan He
2016-10-20 11:37 ` Baoquan He
2016-10-20 11:37 ` Baoquan He
2016-10-20 11:37 ` [PATCH v6 7/9] iommu/amd: Update domain into to dte entry during device driver init Baoquan He
2016-10-20 11:37 ` Baoquan He
2016-10-20 11:37 ` Baoquan He
2016-11-10 11:48 ` Joerg Roedel [this message]
2016-11-13 5:17 ` Baoquan He
2016-11-13 5:17 ` Baoquan He
2016-11-13 5:17 ` Baoquan He
2016-10-20 11:37 ` [PATCH v6 8/9] iommu/amd: Add sanity check of irq remap information of old dev table entry Baoquan He
2016-10-20 11:37 ` Baoquan He
2016-10-20 11:37 ` Baoquan He
2016-10-20 11:37 ` [PATCH v6 9/9] iommu/amd: Don't copy GCR3 table root pointer Baoquan He
2016-10-20 11:37 ` Baoquan He
2016-10-20 11:37 ` Baoquan He
2016-11-04 5:14 ` [PATCH v6 0/9] Fix kdump faults on system with amd iommu Baoquan He
2016-11-04 5:14 ` Baoquan He
2016-11-04 5:14 ` Baoquan He
2016-11-04 5:29 ` Baoquan He
2016-11-04 5:29 ` Baoquan He
2016-11-04 5:29 ` Baoquan He
2016-11-10 11:52 ` Joerg Roedel
2016-11-13 5:07 ` Baoquan He
2016-11-13 5:07 ` Baoquan He
2016-11-13 5:07 ` Baoquan He
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161110114816.GE9996@8bytes.org \
--to=joro@8bytes.org \
--cc=Vincent.Wan@amd.com \
--cc=bhe@redhat.com \
--cc=dyoung@redhat.com \
--cc=iommu@lists.linux-foundation.org \
--cc=kexec@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=xlpang@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.