All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: zhi.a.wang@intel.com
Cc: intel-gfx@lists.freedesktop.org, igvt-g-dev@ml01.01.org
Subject: [bug report] drm/i915/gvt: vGPU display virtualization
Date: Thu, 10 Nov 2016 15:54:51 +0300	[thread overview]
Message-ID: <20161110125451.GC18664@mwanda> (raw)

Hello Zhi Wang,

The patch 04d348ae3f0a: "drm/i915/gvt: vGPU display virtualization"
from Apr 25, 2016, leads to the following static checker warning:

	drivers/gpu/drm/i915/gvt/edid.c:506 intel_gvt_i2c_handle_aux_ch_write()
	warn: odd binop '0x0 & 0xff'

drivers/gpu/drm/i915/gvt/edid.c
   501          /* write the return value in AUX_CH_DATA reg which includes:
   502           * ACK of I2C_WRITE
   503           * returned byte if it is READ
   504           */
   505  
   506          aux_data_for_write |= (GVT_AUX_I2C_REPLY_ACK & 0xff) << 24;

GVT_AUX_I2C_REPLY_ACK is 0 << 6.  Which is weird.  The whole line is a
no-op.

   507          vgpu_vreg(vgpu, offset + 4) = aux_data_for_write;
   508  }

regards,
dan carpenter
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

             reply	other threads:[~2016-11-10 12:55 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-10 12:54 Dan Carpenter [this message]
2016-11-11  8:08 ` [igvt-g-dev] [bug report] drm/i915/gvt: vGPU display virtualization Zhenyu Wang
2016-11-11  8:28   ` Chris Wilson
2016-11-11  8:40     ` Zhenyu Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161110125451.GC18664@mwanda \
    --to=dan.carpenter@oracle.com \
    --cc=igvt-g-dev@ml01.01.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=zhi.a.wang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.