From: Christoph Hellwig <hch@lst.de>
To: Hannes Reinecke <hare@suse.de>
Cc: Christoph Hellwig <hch@lst.de>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
James Bottomley <james.bottomley@hansenpartnership.com>,
linux-scsi@vger.kernel.org, Hannes Reinecke <hare@suse.com>,
Don Brace <don.brace@microsemi.com>
Subject: Re: [PATCH] hpsa: switch to pci_alloc_irq_vectors
Date: Thu, 10 Nov 2016 15:48:02 +0100 [thread overview]
Message-ID: <20161110144802.GA5984@lst.de> (raw)
In-Reply-To: <864f9185-4485-7903-8779-1b16f9a3bed9@suse.de>
On Thu, Nov 10, 2016 at 07:48:20AM +0100, Hannes Reinecke wrote:
> What I find quite irritating is that we still have to call
> irq_set_affinity_hint(irq, NULL) when freeing up interrupts.
> Can't we roll that into the call to free_irq() ?
If you do call it that's irritation, because you should not call
irq_set_affinity_hint ever if you are using PCI_IRQ_AFFINITY, and
the above branch doesn't call it.
> And you _do_ have to setup a cpumap within the driver :-)
For the non-mq case, yes - but only to keep the functionality
as-is. We shouldn't add anything like this to a new driver.
> Anyway, remainder looks pretty close to what I've written up.
> Feel free to add my 'Reviewed-by:' to it.
I'm mostly looking for someone who has the hardware to actually
test it, though.
next prev parent reply other threads:[~2016-11-10 14:48 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-08 7:12 [PATCH] hpsa: switch to pci_alloc_irq_vectors Hannes Reinecke
2016-11-08 14:58 ` Christoph Hellwig
2016-11-08 15:00 ` Hannes Reinecke
2016-11-08 15:01 ` Christoph Hellwig
2016-11-08 15:02 ` Hannes Reinecke
2016-11-08 15:08 ` Christoph Hellwig
2016-11-09 21:39 ` Christoph Hellwig
2016-11-10 6:48 ` Hannes Reinecke
2016-11-10 14:48 ` Christoph Hellwig [this message]
2016-11-10 14:50 ` Hannes Reinecke
2016-11-09 15:32 ` Don Brace
2016-11-09 15:36 ` Christoph Hellwig
2016-11-09 15:45 ` Hannes Reinecke
2016-11-09 21:30 ` Don Brace
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161110144802.GA5984@lst.de \
--to=hch@lst.de \
--cc=don.brace@microsemi.com \
--cc=hare@suse.com \
--cc=hare@suse.de \
--cc=james.bottomley@hansenpartnership.com \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.