From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43336) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c4p0U-0005k4-7P for qemu-devel@nongnu.org; Thu, 10 Nov 2016 08:03:12 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c4p0O-0003dO-IE for qemu-devel@nongnu.org; Thu, 10 Nov 2016 08:03:06 -0500 Received: from mx1.redhat.com ([209.132.183.28]:45426) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1c4p0O-0003c5-9t for qemu-devel@nongnu.org; Thu, 10 Nov 2016 08:03:00 -0500 Date: Thu, 10 Nov 2016 15:02:53 +0200 From: "Michael S. Tsirkin" Message-ID: <20161110150121-mutt-send-email-mst@kernel.org> References: <1477632235-72496-1-git-send-email-arei.gonglei@huawei.com> <1477632235-72496-2-git-send-email-arei.gonglei@huawei.com> <989f16d4-1854-24b5-cf79-dbdd7f4255b0@linux.vnet.ibm.com> <33183CC9F5247A488A2544077AF19020B0421668@SZXEMA503-MBS.china.huawei.com> <20161109173948-mutt-send-email-mst@kernel.org> <33183CC9F5247A488A2544077AF19020B0428688@SZXEMA503-MBS.china.huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <33183CC9F5247A488A2544077AF19020B0428688@SZXEMA503-MBS.china.huawei.com> Subject: Re: [Qemu-devel] [virtio-dev] Re: [PATCH v13 1/2] virtio-crypto: Add virtio crypto device specification List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Gonglei (Arei)" Cc: Halil Pasic , "qemu-devel@nongnu.org" , "virtio-dev@lists.oasis-open.org" , "Huangweidong (C)" , "john.griffin@intel.com" , Shiqing Fan , "Zhoujian (jay, Euler)" , "Varun.Sethi@freescale.com" , "denglingli@chinamobile.com" , "arei.gonglei@hotmail.com" , "Hanweidong (Randy)" , "agraf@suse.de" , "nmorey@kalray.eu" , "vincent.jardin@6wind.com" , "Ola.Liljedahl@arm.com" , Luonengjun , "xin.zeng@intel.com" , "Huangpeng (Peter)" , "liang.j.ma@intel.com" , "stefanha@redhat.com" , "cornelia.huck@de.ibm.com" , Jani Kokkonen , "brian.a.keating@intel.com" , Claudio Fontana , "mike.caraman@nxp.com" , "Wubin (H)" On Thu, Nov 10, 2016 at 02:25:44AM +0000, Gonglei (Arei) wrote: > > > > > Subject: [virtio-dev] Re: [Qemu-devel] [PATCH v13 1/2] virtio-crypto: Add virtio > > crypto device specification > > > > On Wed, Nov 09, 2016 at 01:11:20AM +0000, Gonglei (Arei) wrote: > > > Nope, Actually I kept those description here is because I wanted to represent > > each packet > > > Intuitionally, otherwise I don't know how to explain them only occupy one > > entry in desc table > > > by indirect table method. > > > > whether to use the indirect method should not be up to device. > > I don't see where does the spec require indirect method, > > ANY_LAYOUT is implied so spec should not dictate that IMO. > > > Yes, I reread the virtio spec. And > > 2.4.4 says: > " The framing of messages with descriptors is independent of the contents of the buffers." > > 2.4.4.2 says: > "The driver SHOULD NOT use an excessive number of descriptors to describe a buffer." > > For virtio-crypto, I think I can just add a NOTE to remind people using indirect method > if they want to get better performance in production environment, can I? > > > Thanks, > -Gonglei I'm not sure why frankly. Is there a reason crypto is special here? > > > So I changed the code completely as Stefan's suggestion and > > > revised the spec a little. > > > > > > This just is a representative of the realization so that the people can easily > > understand what > > > the virtio crypto request's components. It isn't completely same with the > > code. > > > For virtio-scsi device, the struct virtio_scsi_req_cmd also used this way IIUR. > > > > > > Thanks, > > > -Gonglei > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org > > For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org