From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55894) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c4t25-0002Lf-Cz for qemu-devel@nongnu.org; Thu, 10 Nov 2016 12:21:05 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c4t20-0001pr-5E for qemu-devel@nongnu.org; Thu, 10 Nov 2016 12:21:01 -0500 Received: from mx1.redhat.com ([209.132.183.28]:54660) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1c4t1z-0001oh-SA for qemu-devel@nongnu.org; Thu, 10 Nov 2016 12:20:56 -0500 Date: Thu, 10 Nov 2016 19:20:53 +0200 From: "Michael S. Tsirkin" Message-ID: <20161110190601-mutt-send-email-mst@kernel.org> References: <1478794177-29377-1-git-send-email-mst@redhat.com> <1478794177-29377-6-git-send-email-mst@redhat.com> <20161110170503.GE31855@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: <20161110170503.GE31855@redhat.com> Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PULL 05/47] contrib: add libvhost-user List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Daniel P. Berrange" Cc: qemu-devel@nongnu.org, Peter Maydell , =?iso-8859-1?Q?Marc-Andr=E9?= Lureau , Felipe Franciosi , Paolo Bonzini , Stefan Hajnoczi , Eric Blake , Markus Armbruster On Thu, Nov 10, 2016 at 05:05:03PM +0000, Daniel P. Berrange wrote: > On Thu, Nov 10, 2016 at 06:12:03PM +0200, Michael S. Tsirkin wrote: > > From: Marc-Andr=E9 Lureau > >=20 > > Add a library to help implementing vhost-user backend (or slave). > >=20 > > Dealing with vhost-user as an application developer isn't so easy: yo= u > > have all the trouble with any protocol: validation, unix ancillary da= ta, > > shared memory, eventfd, logging, and on top of that you need to deal > > with virtio queues, if possible efficiently. > >=20 > > qemu test has a nice vhost-user testing application vhost-user-bridge= , > > which implements most of vhost-user, and virtio.c which implements > > virtqueues manipulation. Based on these two, I tried to make a simple > > library, reusable for tests or development of new vhost-user scenario= s. >=20 > By "new vhost-user scenarios" does this mean facilitating creation of > vhost user clients by out of tree 3rd parties ? Just more tests at this point. > Unless I'm missing something, the change doesn't actually build any > .so of this code, so only thing that can use it right now is other > QEMU code. >=20 > If we want 3rd parties to use this, then it seems to me that LGPLv2+ or > even a BSD like license would be more applicable than GPLv2+. Also we > would need to state what API/ABI stability guarantees we're going to > provide and create a versioned ELF .so. We can discuss this when someone tries to do this. > In general this patch looks like it is something to propose in 2.9, > rather than pushing feature work in post-freeze. >=20 > Regards, > Daniel >>From my perspective, anything that helps find failures at user systems during build and not when running guests is a plus. > --=20 > |: http://berrange.com -o- http://www.flickr.com/photos/dberran= ge/ :| > |: http://libvirt.org -o- http://virt-manager.= org :| > |: http://entangle-photo.org -o- http://search.cpan.org/~danbe= rr/ :|