From: Dan Carpenter <dan.carpenter@oracle.com>
To: Anton Leshchenko <antonl1911@gmail.com>
Cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/4] Staging: vme: Use BIT macro for bit field definitions.
Date: Thu, 10 Nov 2016 22:17:23 +0300 [thread overview]
Message-ID: <20161110191723.GE28701@mwanda> (raw)
In-Reply-To: <20161101222711.17089-2-antonl1911@gmail.com>
On Wed, Nov 02, 2016 at 01:27:09AM +0300, Anton Leshchenko wrote:
> #define PIO2_CNTR_MODE0 0
> -#define PIO2_CNTR_MODE1 (1 << 1)
> -#define PIO2_CNTR_MODE2 (2 << 1)
> -#define PIO2_CNTR_MODE3 (3 << 1)
> -#define PIO2_CNTR_MODE4 (4 << 1)
> -#define PIO2_CNTR_MODE5 (5 << 1)
> +#define PIO2_CNTR_MODE1 BIT(1)
> +#define PIO2_CNTR_MODE2 BIT(2)
> +#define PIO2_CNTR_MODE3 (BIT(1) | BIT(2))
> +#define PIO2_CNTR_MODE4 BIT(4)
This should be BIT(3)
> +#define PIO2_CNTR_MODE5 (BIT(1) | BIT(3))
regards,
dan carpenter
next prev parent reply other threads:[~2016-11-10 19:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-01 22:27 [PATCH 1/4] Staging: vme: Remove excessive blank lines Anton Leshchenko
2016-11-01 22:27 ` [PATCH 2/4] Staging: vme: Use BIT macro for bit field definitions Anton Leshchenko
2016-11-10 19:17 ` Dan Carpenter [this message]
2016-11-14 14:46 ` Greg KH
2016-11-01 22:27 ` [PATCH 3/4] Staging: vme: Add required identifier names Anton Leshchenko
2016-11-01 22:27 ` [PATCH 4/4] Staging: vme: Fix parenthesis alignment Anton Leshchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161110191723.GE28701@mwanda \
--to=dan.carpenter@oracle.com \
--cc=antonl1911@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.