From: Christoph Hellwig <hch@lst.de>
To: Bart Van Assche <bart.vanassche@sandisk.com>
Cc: Christoph Hellwig <hch@lst.de>,
axboe@kernel.dk, linux-block@vger.kernel.org
Subject: Re: [PATCH] block: clear all of bi_opf in bio_set_op_attrs
Date: Thu, 10 Nov 2016 20:29:37 +0100 [thread overview]
Message-ID: <20161110192937.GA21189@lst.de> (raw)
In-Reply-To: <469312f1-e28c-0618-9df1-7c636b5c9e0d@sandisk.com>
On Thu, Nov 10, 2016 at 08:31:11AM -0800, Bart Van Assche wrote:
> Have you verified whether or not this change affects the behavior of the
> bcache driver? From commit ad0d9e76a412:
It doesn't, bcache only calls bch_data_verify from a read completion
handler.
> Additionally, since bio_set_op_attrs is a macro please surround 'op' and
> 'op_flags' with parentheses or change this macro into an inline function.
Makese sense, thanks.
next prev parent reply other threads:[~2016-11-10 19:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-09 18:38 [PATCH] block: clear all of bi_opf in bio_set_op_attrs Christoph Hellwig
2016-11-10 16:31 ` Bart Van Assche
2016-11-10 19:29 ` Christoph Hellwig [this message]
-- strict thread matches above, loose matches on Subject: below --
2016-11-21 15:18 Christoph Hellwig
2016-11-21 16:35 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161110192937.GA21189@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=bart.vanassche@sandisk.com \
--cc=linux-block@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.