From: Tony Lindgren <tony@atomide.com>
To: Brian Norris <briannorris@chromium.org>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
"Rafael J . Wysocki" <rjw@rjwysocki.net>,
Pavel Machek <pavel@ucw.cz>, Len Brown <len.brown@intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
lkml <linux-kernel@vger.kernel.org>,
Brian Norris <computersforpeace@gmail.com>,
"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>
Subject: Re: [PATCH] PM / wakeirq: report wakeup events in dedicated wake-IRQs
Date: Thu, 10 Nov 2016 13:49:11 -0700 [thread overview]
Message-ID: <20161110204911.GK27724@atomide.com> (raw)
In-Reply-To: <20161110184910.GA135921@google.com>
* Brian Norris <briannorris@chromium.org> [161110 11:49]:
> On Thu, Nov 10, 2016 at 10:13:55AM -0800, Dmitry Torokhov wrote:
> > On Thu, Nov 10, 2016 at 10:07 AM, Brian Norris <briannorris@chromium.org> wrote:
> > > It's important that user space can figure out what device woke the
> > > system from suspend -- e.g., for debugging, or for implementing
> > > conditional wake behavior. Dedicated wakeup IRQs don't currently do
> > > that.
> > >
> > > Let's report the event (pm_wakeup_event()) and also allow drivers to
> > > synchronize with these events in their resume path (hence, disable_irq()
> > > instead of disable_irq_nosync()).
> >
> > Hmm, dev_pm_disable_wake_irq() is called from
> > rpm_suspend()/rpm_resume() that take dev->power.lock spinlock and
> > disable interrupts. Dropping _nosync() feels dangerous.
>
> Indeed. So how do you suggest we get sane wakeup reports?
__pm_wakeup_event() ?
Tony
next prev parent reply other threads:[~2016-11-10 20:49 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-10 18:07 [PATCH] PM / wakeirq: report wakeup events in dedicated wake-IRQs Brian Norris
2016-11-10 18:07 ` Brian Norris
2016-11-10 18:13 ` Dmitry Torokhov
2016-11-10 18:49 ` Brian Norris
2016-11-10 20:49 ` Tony Lindgren [this message]
2016-11-10 21:30 ` Brian Norris
2016-11-11 16:47 ` Tony Lindgren
2016-11-11 19:40 ` Brian Norris
2016-11-11 20:17 ` Tony Lindgren
2016-11-11 21:09 ` Alan Stern
2016-11-11 21:40 ` Rafael J. Wysocki
2016-11-11 0:06 ` Rafael J. Wysocki
2016-11-11 16:31 ` Tony Lindgren
2016-11-11 21:33 ` Rafael J. Wysocki
2016-11-11 22:29 ` Tony Lindgren
2016-11-11 22:32 ` Tony Lindgren
2016-11-11 23:34 ` Rafael J. Wysocki
2016-11-12 0:19 ` Tony Lindgren
2016-11-12 0:35 ` Rafael J. Wysocki
2016-11-18 20:18 ` Tony Lindgren
2016-11-23 22:37 ` Rafael J. Wysocki
2016-11-24 14:27 ` Tony Lindgren
2016-11-10 20:57 ` Pavel Machek
2016-11-10 21:39 ` Brian Norris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161110204911.GK27724@atomide.com \
--to=tony@atomide.com \
--cc=briannorris@chromium.org \
--cc=computersforpeace@gmail.com \
--cc=dmitry.torokhov@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.