From: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
To: Guenter Roeck <linux@roeck-us.net>,
Mahoda Ratnayaka <mahoda.ratnayaka@alliedtelesis.co.nz>
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-hwmon@vger.kernel.org
Subject: Re: [PATCH] lm87: Allow LM87_REG_CHANNEL_MODE to be set via DT
Date: Thu, 10 Nov 2016 17:31:40 -0700 [thread overview]
Message-ID: <20161111003140.GA7575@obsidianresearch.com> (raw)
In-Reply-To: <20161110234707.GA14199@roeck-us.net>
On Thu, Nov 10, 2016 at 03:47:07PM -0800, Guenter Roeck wrote:
> On Thu, Nov 10, 2016 at 10:19:36AM -0700, Jason Gunthorpe wrote:
> > This compliments the existing scheme that lets it be set via
> > platform_data.
> >
> > Signed-off-by: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
>
> I would prefer https://www.spinics.net/lists/devicetree/msg148819.html
> which appears to address the same problem and is less cryptic.
Is there a patch someplace that implements that proposed DT binding? I
couldn't find anything.
> NACK unless someone convinces me otherwise.
*shrug* both styles of definition seem to be used in various device
tree bindings.
The downside with Mahoda's proposal is that it only covers 3 of the 8
configuration bits, and will require alot of code for parsing. It
seems really clunky, and why is a regulator involved to set the A/D
sensitivity? Weird.
But I only need has-temp3, so if a patch appears please cc me and I'll
review it here..
Regards,
Jason
prev parent reply other threads:[~2016-11-11 0:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-10 17:19 [PATCH] lm87: Allow LM87_REG_CHANNEL_MODE to be set via DT Jason Gunthorpe
2016-11-10 23:47 ` Guenter Roeck
2016-11-11 0:31 ` Jason Gunthorpe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161111003140.GA7575@obsidianresearch.com \
--to=jgunthorpe@obsidianresearch.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=mahoda.ratnayaka@alliedtelesis.co.nz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.