Re: [PATCH 1/5] NFSv4: Don't check file access when reclaiming state

[kbuild test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 2528 bytes --]

Hi Trond,

[auto build test WARNING on nfs/linux-next]
[also build test WARNING on v4.9-rc4 next-20161110]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Trond-Myklebust/Optimisations-for-state-management/20161111-054856
base:   git://git.linux-nfs.org/projects/trondmy/linux-nfs.git linux-next
config: x86_64-eywa-module (attached as .config)
compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

All warnings (new ones prefixed by >>):

   fs/nfs/nfs4proc.c: In function 'nfs4_opendata_alloc':
>> fs/nfs/nfs4proc.c:1232:3: warning: enumeration value 'NFS4_OPEN_CLAIM_PREVIOUS' not handled in switch [-Wswitch]
      switch (p->o_arg.claim) {
      ^~~~~~
>> fs/nfs/nfs4proc.c:1232:3: warning: enumeration value 'NFS4_OPEN_CLAIM_DELEGATE_CUR' not handled in switch [-Wswitch]
>> fs/nfs/nfs4proc.c:1232:3: warning: enumeration value 'NFS4_OPEN_CLAIM_DELEGATE_PREV' not handled in switch [-Wswitch]
>> fs/nfs/nfs4proc.c:1232:3: warning: enumeration value 'NFS4_OPEN_CLAIM_DELEG_CUR_FH' not handled in switch [-Wswitch]
>> fs/nfs/nfs4proc.c:1232:3: warning: enumeration value 'NFS4_OPEN_CLAIM_DELEG_PREV_FH' not handled in switch [-Wswitch]

vim +/NFS4_OPEN_CLAIM_PREVIOUS +1232 fs/nfs/nfs4proc.c

  1216			goto err_free_label;
  1217		nfs_sb_active(dentry->d_sb);
  1218		p->dentry = dget(dentry);
  1219		p->dir = parent;
  1220		p->owner = sp;
  1221		atomic_inc(&sp->so_count);
  1222		p->o_arg.open_flags = flags;
  1223		p->o_arg.fmode = fmode & (FMODE_READ|FMODE_WRITE);
  1224		p->o_arg.claim = nfs4_map_atomic_open_claim(server, claim);
  1225		p->o_arg.share_access = nfs4_map_atomic_open_share(server,
  1226				fmode, flags);
  1227		/* don't put an ACCESS op in OPEN compound if O_EXCL, because ACCESS
  1228		 * will return permission denied for all bits until close */
  1229		if (!(flags & O_EXCL)) {
  1230			/* ask server to check for all possible rights as results
  1231			 * are cached */
> 1232			switch (p->o_arg.claim) {
  1233			case NFS4_OPEN_CLAIM_NULL:
  1234			case NFS4_OPEN_CLAIM_FH:
  1235				p->o_arg.access = NFS4_ACCESS_READ |
  1236					NFS4_ACCESS_MODIFY |
  1237					NFS4_ACCESS_EXTEND |
  1238					NFS4_ACCESS_EXECUTE;
  1239			}
  1240		}

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 25516 bytes --]