From: Dan Carpenter <dan.carpenter@oracle.com>
To: kernel-janitors@vger.kernel.org
Subject: Re: [bug report] vxlan: keep flags and vni in network byte order
Date: Fri, 11 Nov 2016 13:27:08 +0000 [thread overview]
Message-ID: <20161111132708.GJ28558@mwanda> (raw)
In-Reply-To: <20161111124941.GA3991@mwanda>
On Fri, Nov 11, 2016 at 02:12:03PM +0100, Jiri Benc wrote:
> On Fri, 11 Nov 2016 14:05:09 +0100, Jiri Benc wrote:
> > The static checker clearly can't understand endian conversion macros.
> > VXLAN_VNI_MASK is:
> >
> > cpu_to_be32(VXLAN_VID_MASK << 8)
> >
> > Thus on little endian, it becomes 0x00ffffff.
Ah right.
>
> Btw, until the unspecified static checker you used is not fixed to
> resolve such macros correctly, it can't be really used to check the
> kernel source, yet alone to generate bug reports. It will trip over
> false positive in gazillion places.
Nope. Just this one.
regards,
dan carpenter
prev parent reply other threads:[~2016-11-11 13:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-11 12:49 [bug report] vxlan: keep flags and vni in network byte order Dan Carpenter
2016-11-11 13:05 ` Jiri Benc
2016-11-11 13:12 ` Jiri Benc
2016-11-11 13:27 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161111132708.GJ28558@mwanda \
--to=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.