From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tom Rini Date: Fri, 11 Nov 2016 11:20:47 -0500 Subject: [U-Boot] [PATCH 4/7] tools: sunxi: Add spl image builder In-Reply-To: <312ad66b8bd78b877f82ebd2fb16efcbb51e0a15.1478621974.git-series.maxime.ripard@free-electrons.com> References: <312ad66b8bd78b877f82ebd2fb16efcbb51e0a15.1478621974.git-series.maxime.ripard@free-electrons.com> Message-ID: <20161111162047.GI27304@bill-the-cat> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Tue, Nov 08, 2016 at 05:21:14PM +0100, Maxime Ripard wrote: > This program generates raw SPL images that can be flashed on the NAND with > the ECC and randomizer properly set up. > > Signed-off-by: Maxime Ripard [snip] > +++ b/tools/sunxi-spl-image-builder.c > @@ -0,0 +1,1113 @@ > +/* > + * Generic binary BCH encoding/decoding library OK, but this is also lib/bch.c and re-using lib/ code for tools is a normal best practice. I'd suggest re-factoring this code in sunxi-tools sot that it too borrows lib/bch.c from the kernel (and can re-sync bugfixes if needed). Thanks! -- Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: Digital signature URL: