From: Peter Zijlstra <peterz@infradead.org>
To: "Rafael J. Wysocki" <rafael@kernel.org>
Cc: Viresh Kumar <viresh.kumar@linaro.org>,
Rafael Wysocki <rjw@rjwysocki.net>,
Ingo Molnar <mingo@redhat.com>,
Lists linaro-kernel <linaro-kernel@lists.linaro.org>,
Linux PM <linux-pm@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Vincent Guittot <vincent.guittot@linaro.org>,
Juri Lelli <Juri.Lelli@arm.com>,
Robin Randhawa <robin.randhawa@arm.com>
Subject: Re: [PATCH 1/3] cpufreq: schedutil: enable fast switch earlier
Date: Fri, 11 Nov 2016 23:55:20 +0100 [thread overview]
Message-ID: <20161111225520.GC3142@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <CAJZ5v0jem_tAOJM-zHyQ4kAmF+gmv85E3KnG9M1=1qi6vVQitA@mail.gmail.com>
On Fri, Nov 11, 2016 at 10:52:27PM +0100, Rafael J. Wysocki wrote:
> On Fri, Nov 11, 2016 at 3:19 PM, Peter Zijlstra <peterz@infradead.org> wrote:
> > On Fri, Nov 11, 2016 at 03:52:21PM +0530, Viresh Kumar wrote:
> >> @@ -456,8 +460,6 @@ static int sugov_init(struct cpufreq_policy *policy)
> >>
> >> out:
> >> mutex_unlock(&global_tunables_lock);
> >> -
> >> - cpufreq_enable_fast_switch(policy);
> >> return 0;
> >>
> >> fail:
> >> @@ -468,6 +470,10 @@ static int sugov_init(struct cpufreq_policy *policy)
> >> mutex_unlock(&global_tunables_lock);
> >>
> >> sugov_policy_free(sg_policy);
> >> +
> >> + disable_fast_switch:
> >> + cpufreq_disable_fast_switch(policy);
> >> +
> >> pr_err("initialization failed (error %d)\n", ret);
> >> return ret;
> >> }
> >
> > Argh, no indented labels please. Please fix the 3 that snuck in while
> > you're there.
>
> Well, you didn't tell me you didn't like them. :-)
>
> Anyway, I can fix this up easily enough.
>
> Any other concerns regarding the patch?
No, looked fine I think, as did the others.
next prev parent reply other threads:[~2016-11-11 22:55 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-11 10:22 [PATCH 0/3] cpufreq: schedutil: move slow path from workqueue to SCHED_FIFO task Viresh Kumar
2016-11-11 10:22 ` [PATCH 1/3] cpufreq: schedutil: enable fast switch earlier Viresh Kumar
2016-11-11 14:19 ` Peter Zijlstra
2016-11-11 21:52 ` Rafael J. Wysocki
2016-11-11 22:55 ` Peter Zijlstra [this message]
2016-11-11 21:58 ` Rafael J. Wysocki
2016-11-12 5:19 ` Viresh Kumar
2016-11-13 14:46 ` Rafael J. Wysocki
2016-11-14 4:06 ` Viresh Kumar
2016-11-14 11:30 ` Viresh Kumar
2016-11-11 10:22 ` [PATCH 2/3] cpufreq: schedutil: move slow path from workqueue to SCHED_FIFO task Viresh Kumar
2016-11-11 14:32 ` Tommaso Cucinotta
2016-11-11 14:39 ` Peter Zijlstra
2016-11-12 5:22 ` Viresh Kumar
2016-11-14 9:22 ` Peter Zijlstra
2016-11-14 10:22 ` Viresh Kumar
2016-11-12 5:21 ` Viresh Kumar
2016-11-11 22:16 ` Rafael J. Wysocki
2016-11-12 1:31 ` Saravana Kannan
2016-11-12 5:27 ` Viresh Kumar
2016-11-14 5:37 ` Viresh Kumar
2016-11-13 14:37 ` Rafael J. Wysocki
2016-11-13 19:47 ` Steve Muckle
2016-11-13 22:44 ` Rafael J. Wysocki
2016-11-14 6:36 ` Viresh Kumar
2016-11-12 5:24 ` Viresh Kumar
2016-11-13 19:31 ` Steve Muckle
2016-11-11 10:22 ` [PATCH 3/3] cpufreq: schedutil: irq-work is used only in slow path Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161111225520.GC3142@twins.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=Juri.Lelli@arm.com \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=rafael@kernel.org \
--cc=rjw@rjwysocki.net \
--cc=robin.randhawa@arm.com \
--cc=vincent.guittot@linaro.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.