From: Keith Busch <keith.busch@intel.com>
To: Jon Derrick <jonathan.derrick@intel.com>
Cc: helgaas@kernel.org, linux-pci@vger.kernel.org
Subject: Re: [PATCH 2/2] PCI/VMD: Select SRCU
Date: Fri, 11 Nov 2016 18:10:00 -0500 [thread overview]
Message-ID: <20161111230959.GC10660@localhost.localdomain> (raw)
In-Reply-To: <1478904657-11342-2-git-send-email-jonathan.derrick@intel.com>
On Fri, Nov 11, 2016 at 03:50:57PM -0700, Jon Derrick wrote:
> VMD now uses SRCU, so we must qualify that it is part of the kernel.
>
> Signed-off-by: Jon Derrick <jonathan.derrick@intel.com>
> ---
> drivers/pci/host/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/pci/host/Kconfig b/drivers/pci/host/Kconfig
> index d7e7c0a..80ffa66 100644
> --- a/drivers/pci/host/Kconfig
> +++ b/drivers/pci/host/Kconfig
> @@ -287,6 +287,7 @@ config PCIE_ROCKCHIP
>
> config VMD
> depends on PCI_MSI && X86_64
> + select SRCU
> tristate "Intel Volume Management Device Driver"
> default N
> ---help---
I think it'd be better to squash this patch with the first in this series,
and append SRCU to the 'depends on' section rather than select it.
I get the feeling that having both 'select' and 'depends on' in the
Kconfig syntax is not a well loved feature:
https://www.linuxplumbersconf.org/2016/ocw/proposals/4605
prev parent reply other threads:[~2016-11-11 23:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-11 22:50 [PATCH 1/2] PCI/VMD: Use SRCU as a local RCU to prevent delaying global RCU Jon Derrick
2016-11-11 22:50 ` [PATCH 2/2] PCI/VMD: Select SRCU Jon Derrick
2016-11-11 23:10 ` Keith Busch [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161111230959.GC10660@localhost.localdomain \
--to=keith.busch@intel.com \
--cc=helgaas@kernel.org \
--cc=jonathan.derrick@intel.com \
--cc=linux-pci@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.