From: Wei Liu <wei.liu2@citrix.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: ian.jackson@eu.citrix.com,
Boris Ostrovsky <boris.ostrovsky@oracle.com>,
wei.liu2@citrix.com, Jan Beulich <JBeulich@suse.com>,
xen-devel@lists.xen.org
Subject: Re: [PATCH for-4.8] libxc/x86: Report consistent initial APIC value for PV guests
Date: Sat, 12 Nov 2016 06:46:29 +0000 [thread overview]
Message-ID: <20161112064629.GD24290@citrix.com> (raw)
In-Reply-To: <c50c1802-9939-de93-24d9-54b3d8ce3d5a@citrix.com>
On Fri, Nov 11, 2016 at 03:33:11PM +0000, Andrew Cooper wrote:
> On 11/11/16 15:32, Jan Beulich wrote:
> >>>> On 11.11.16 at 16:16, <wei.liu2@citrix.com> wrote:
> >> On Thu, Nov 10, 2016 at 09:50:24AM -0500, Boris Ostrovsky wrote:
> >>> Currently hypervisor provides PV guest's CPUID(1).EBX[31:24] (initial
> >>> APIC ID) with contents of that field on the processor that launched
> >>> the guest. This results in the guest reporting different initial
> >>> APIC IDs across runs.
> >>>
> >>> We should be consistent in how this value is reported, let's set
> >>> it to 0 (which is also what Linux guests expect).
> >>>
> >>> Signed-off-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
> >> I will defer this to x86 maintainers.
> > Changing from a random (wrong) value to a deterministic (but still
> > wrong) value certainly won't make things worse. IOW the patch
> > can have my ack if needed, but I thought I had seen Andrew
> > already give his.
>
> I don't think I had explicitly, but here...
>
> Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>
Applied.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
prev parent reply other threads:[~2016-11-12 6:46 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-10 14:50 [PATCH for-4.8] libxc/x86: Report consistent initial APIC value for PV guests Boris Ostrovsky
2016-11-10 14:55 ` Andrew Cooper
2016-11-10 15:05 ` Boris Ostrovsky
2016-11-10 15:08 ` Andrew Cooper
2016-11-10 15:24 ` Boris Ostrovsky
2016-11-10 16:12 ` Jan Beulich
2016-11-10 16:24 ` Boris Ostrovsky
2016-11-10 16:24 ` Andrew Cooper
2016-11-11 15:16 ` Wei Liu
2016-11-11 15:32 ` Jan Beulich
2016-11-11 15:33 ` Andrew Cooper
2016-11-12 6:46 ` Wei Liu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161112064629.GD24290@citrix.com \
--to=wei.liu2@citrix.com \
--cc=JBeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=boris.ostrovsky@oracle.com \
--cc=ian.jackson@eu.citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.