From: Wei Liu <wei.liu2@citrix.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: xen-devel <xen-devel@lists.xenproject.org>,
Wei Liu <wei.liu2@citrix.com>, Jan Beulich <JBeulich@suse.com>
Subject: Re: [PATCH] x86/EFI: meet further spec requirements for runtime calls
Date: Sat, 12 Nov 2016 06:48:50 +0000 [thread overview]
Message-ID: <20161112064850.GE24290@citrix.com> (raw)
In-Reply-To: <2e1094e0-6ae9-49a8-9f41-a2658f217a29@citrix.com>
On Fri, Nov 11, 2016 at 03:39:26PM +0000, Andrew Cooper wrote:
> On 10/11/16 16:06, Jan Beulich wrote:
> > So far we didn't guarantee 16-byte alignment of the stack: While (so
> > far) we don't tell the compiler to use smaller alignment, we also don't
> > guarantee 16-byte alignment when establishing stack pointers for new
> > vCPU-s. Runtime service functions using SSE instructions may end with
> > #GP(0) without that.
> >
> > Note that -mpreferred-stack-boundary=3 is can be used only from gcc 4.8
> > onwards, and -mincoming-stack-boundary=3 only from 5.3 onwards. It is
> > for that reason that an alternative approach (using higher than
> > necessary alignment) is being used when building with such older
> > compilers.
> >
> > Furthermore we should avoid #MF to be raised on the FLDCW we do.
> >
> > Signed-off-by: Jan Beulich <jbeulich@suse.com>
>
> Acked-by: Andrew Cooper <andrew.cooper3@citrix.com>
Applied.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-11-12 6:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-10 16:06 [PATCH] x86/EFI: meet further spec requirements for runtime calls Jan Beulich
2016-11-11 15:39 ` Andrew Cooper
2016-11-12 6:48 ` Wei Liu [this message]
2016-11-14 7:50 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161112064850.GE24290@citrix.com \
--to=wei.liu2@citrix.com \
--cc=JBeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.