From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Lindgren Subject: Re: [PATCH 3/3] rtc: rtc-twl: use irq_of_parse_and_map helper Date: Sat, 12 Nov 2016 09:58:46 -0800 Message-ID: <20161112175845.GP7138@atomide.com> References: <1478945246-32056-1-git-send-email-Nicolae_Rosia@mentor.com> <1478945246-32056-4-git-send-email-Nicolae_Rosia@mentor.com> <20161112112009.34gwcedl57v77ng5@earth> Reply-To: rtc-linux-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: Sender: rtc-linux-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org Content-Disposition: inline In-Reply-To: List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , To: Nicolae Rosia Cc: Sebastian Reichel , Nicolae Rosia , Alessandro Zummo , Alexandre Belloni , rtc-linux-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org, linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-omap@vger.kernel.org * Nicolae Rosia [161112 03:37]: > Hi, > > > On Sat, Nov 12, 2016 at 1:20 PM, Sebastian Reichel wrote: > > This patch is missing long description. I would have patched it the > > other way around. There is no reason to use irq_of_parse_and_map if > > generic platform_get_irq can be used. > Since this patch series removes platform support and makes the driver DT only, > I thought it would be a good idea to make it explicit that it depends on OF_IRQ. You can still use platform_get_irq(), eventually that will be just some generic call. Don't we already have the "generic" names defined somewhere in kernel? Regards, Tony -- You received this message because you are subscribed to "rtc-linux". Membership options at http://groups.google.com/group/rtc-linux . Please read http://groups.google.com/group/rtc-linux/web/checklist before submitting a driver. --- You received this message because you are subscribed to the Google Groups "rtc-linux" group. To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe-/JYPxA39Uh5TLH3MbocFF+G/Ez6ZCGd0@public.gmane.org For more options, visit https://groups.google.com/d/optout. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Sender: rtc-linux@googlegroups.com Received: from muru.com (muru.com. [72.249.23.125]) by gmr-mx.google.com with ESMTP id o6si2761978pap.2.2016.11.12.09.58.50 for ; Sat, 12 Nov 2016 09:58:51 -0800 (PST) Date: Sat, 12 Nov 2016 09:58:46 -0800 From: Tony Lindgren To: Nicolae Rosia Cc: Sebastian Reichel , Nicolae Rosia , Alessandro Zummo , Alexandre Belloni , rtc-linux@googlegroups.com, linux-omap@vger.kernel.org Subject: [rtc-linux] Re: [PATCH 3/3] rtc: rtc-twl: use irq_of_parse_and_map helper Message-ID: <20161112175845.GP7138@atomide.com> References: <1478945246-32056-1-git-send-email-Nicolae_Rosia@mentor.com> <1478945246-32056-4-git-send-email-Nicolae_Rosia@mentor.com> <20161112112009.34gwcedl57v77ng5@earth> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 In-Reply-To: Reply-To: rtc-linux@googlegroups.com List-ID: List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , * Nicolae Rosia [161112 03:37]: > Hi, > > > On Sat, Nov 12, 2016 at 1:20 PM, Sebastian Reichel wrote: > > This patch is missing long description. I would have patched it the > > other way around. There is no reason to use irq_of_parse_and_map if > > generic platform_get_irq can be used. > Since this patch series removes platform support and makes the driver DT only, > I thought it would be a good idea to make it explicit that it depends on OF_IRQ. You can still use platform_get_irq(), eventually that will be just some generic call. Don't we already have the "generic" names defined somewhere in kernel? Regards, Tony -- You received this message because you are subscribed to "rtc-linux". Membership options at http://groups.google.com/group/rtc-linux . Please read http://groups.google.com/group/rtc-linux/web/checklist before submitting a driver. --- You received this message because you are subscribed to the Google Groups "rtc-linux" group. To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com. For more options, visit https://groups.google.com/d/optout.