All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrei Gherzan <andrei@gherzan.ro>
To: Jonathan Liu <net147@gmail.com>
Cc: yocto@yoctoproject.org
Subject: Re: [meta-raspberrypi][PATCH] u-boot: Fix appending to RDEPENDS
Date: Sat, 12 Nov 2016 18:48:50 +0000	[thread overview]
Message-ID: <20161112184850.GC32346@carbonA.lan> (raw)
In-Reply-To: <20161101134647.11370-1-net147@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1566 bytes --]

On Wed, Nov 02, 2016 at 12:46:47AM +1100, Jonathan Liu wrote:
> The += operator should not be used in combination with overrides as it
> will clear any existing values in the variable.
>
> Example:
> FOO = "bar"
> FOO_rpi += "baz"
>
> The above example would result in FOO being equal to " baz" instead of
> "bar baz".
>
> The bbappend is changed to use a wildcard instead of a specific version
> to simplify updating U-Boot.
>
> Signed-off-by: Jonathan Liu <net147@gmail.com>
> ---
>  recipes-bsp/u-boot/u-boot_%.bbappend       | 1 +
>  recipes-bsp/u-boot/u-boot_2016.03.bbappend | 1 -
>  2 files changed, 1 insertion(+), 1 deletion(-)
>  create mode 100644 recipes-bsp/u-boot/u-boot_%.bbappend
>  delete mode 100644 recipes-bsp/u-boot/u-boot_2016.03.bbappend
>
> diff --git a/recipes-bsp/u-boot/u-boot_%.bbappend b/recipes-bsp/u-boot/u-boot_%.bbappend
> new file mode 100644
> index 0000000..3781666
> --- /dev/null
> +++ b/recipes-bsp/u-boot/u-boot_%.bbappend
> @@ -0,0 +1 @@
> +RDEPENDS_${PN}_append_rpi = " rpi-u-boot-scr"
> diff --git a/recipes-bsp/u-boot/u-boot_2016.03.bbappend b/recipes-bsp/u-boot/u-boot_2016.03.bbappend
> deleted file mode 100644
> index 35dfc37..0000000
> --- a/recipes-bsp/u-boot/u-boot_2016.03.bbappend
> +++ /dev/null
> @@ -1 +0,0 @@
> -RDEPENDS_${PN}_rpi += "rpi-u-boot-scr"
> --
> 2.10.1
>
> --
> _______________________________________________
> yocto mailing list
> yocto@yoctoproject.org
> https://lists.yoctoproject.org/listinfo/yocto

Merged to master. Thanks.
--
Andrei Gherzan

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 817 bytes --]

      parent reply	other threads:[~2016-11-12 18:49 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-01 13:46 [meta-raspberrypi][PATCH] u-boot: Fix appending to RDEPENDS Jonathan Liu
2016-11-02  8:28 ` Paul Barker
2016-11-03  5:58   ` Khem Raj
2016-11-12 18:48 ` Andrei Gherzan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161112184850.GC32346@carbonA.lan \
    --to=andrei@gherzan.ro \
    --cc=net147@gmail.com \
    --cc=yocto@yoctoproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.