From: Christoph Hellwig <hch@lst.de>
To: Hannes Reinecke <hare@suse.com>
Cc: Christoph Hellwig <hch@infradead.org>,
Hannes Reinecke <hare@suse.de>, Christoph Hellwig <hch@lst.de>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
James Bottomley <james.bottomley@hansenpartnership.com>,
Don Brace <don.brace@microsemi.com>,
linux-scsi@vger.kernel.org, Jens Axboe <axboe@kernel.dk>
Subject: Re: [PATCH] hpsa: scsi-mq support
Date: Sun, 13 Nov 2016 12:58:41 +0100 [thread overview]
Message-ID: <20161113115841.GA4818@lst.de> (raw)
In-Reply-To: <cba051f8-3055-53c4-2860-ee4c51a7043d@suse.com>
On Sun, Nov 13, 2016 at 10:44:47AM +0100, Hannes Reinecke wrote:
> One day to mark with bright red in the calendar.
>
> Christoph Hellwig is telling me _NOT_ to use scsi-mq.
That's not what I'm doing.
> This patch was done so see what would needed to be done to convert a legacy
> driver.
> As I was under the impression that scsi-mq is the way forward, seeing that
> it should be enabled per default.
> But I must have been mistaken. Apparently.
What I am doing is to tell you you should not expose multiple queues
unless the hardware actually has multiple submissions queues. The blk-mq
and scsi-mq code works just fine with a single submission queue, and
the hpsa driver in particular works really well with scsi-mq and a single
submission queue. E.g. the RAID HBA on slide 19 of this presentations is
an hpsa one:
http://events.linuxfoundation.org/sites/events/files/slides/scsi.pdf
next prev parent reply other threads:[~2016-11-13 11:58 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-11 15:46 [PATCH] hpsa: scsi-mq support Hannes Reinecke
2016-11-11 16:34 ` kbuild test robot
2016-11-11 16:35 ` Christoph Hellwig
2016-11-11 18:22 ` Hannes Reinecke
2016-11-12 17:32 ` Christoph Hellwig
2016-11-13 9:44 ` Hannes Reinecke
2016-11-13 11:58 ` Christoph Hellwig [this message]
2016-11-14 11:05 ` Kashyap Desai
2016-11-12 18:30 ` Jens Axboe
2016-11-11 16:57 ` kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161113115841.GA4818@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=don.brace@microsemi.com \
--cc=hare@suse.com \
--cc=hare@suse.de \
--cc=hch@infradead.org \
--cc=james.bottomley@hansenpartnership.com \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.