From: Christoph Hellwig <hch@lst.de>
To: Sagi Grimberg <sagi@grimberg.me>
Cc: Jens Axboe <axboe@kernel.dk>,
linux-block@vger.kernel.org, Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH 3/3] irq-poll: Reduce local_irq_save/restore operations in irq_poll_softirq
Date: Sun, 13 Nov 2016 16:18:02 +0100 [thread overview]
Message-ID: <20161113151802.GD7578@lst.de> (raw)
In-Reply-To: <1478991755-28153-4-git-send-email-sagi@grimberg.me>
> + while (!list_empty(&list)) {
Maybe do a list_first_entry_or_null here if you're touching the list
iteration anyway?
> + local_irq_disable();
> + list_splice_tail_init(iop_list, &list);
> + list_splice(&list, iop_list);
> +
> if (rearm)
> __raise_softirq_irqoff(IRQ_POLL_SOFTIRQ);
Maybe check if we have a non-empty list before disabling irqs?
Also that list_emtpy check can replace the rearm condition - we only
set the rearm flag if we break with a non-empty local list now.
next prev parent reply other threads:[~2016-11-13 15:18 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-12 23:02 [PATCH 0/3] micro-optimize irq-poll Sagi Grimberg
2016-11-12 23:02 ` [PATCH 1/3] irq-poll: Remove redundant include Sagi Grimberg
2016-11-13 15:12 ` Christoph Hellwig
2016-11-12 23:02 ` [PATCH 2/3] irq-poll: micro optimize some branch predictions Sagi Grimberg
2016-11-13 15:13 ` Christoph Hellwig
2016-11-14 0:49 ` Sagi Grimberg
2016-11-12 23:02 ` [PATCH 3/3] irq-poll: Reduce local_irq_save/restore operations in irq_poll_softirq Sagi Grimberg
2016-11-13 15:18 ` Christoph Hellwig [this message]
2016-11-14 1:02 ` Sagi Grimberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161113151802.GD7578@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.