From: Andrew Lunn <andrew@lunn.ch>
To: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
Cc: David Miller <davem@davemloft.net>, netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH net-next 05/11] net: dsa: mv88e6xxx: Add comment about family a device belongs to
Date: Mon, 14 Nov 2016 03:48:52 +0100 [thread overview]
Message-ID: <20161114024852.GA26710@lunn.ch> (raw)
In-Reply-To: <8737iubype.fsf@ketchup.i-did-not-set--mail-host-address--so-tickle-me>
On Mon, Nov 14, 2016 at 01:08:13PM +1100, Vivien Didelot wrote:
> Hi Andrew,
>
> Andrew Lunn <andrew@lunn.ch> writes:
>
> > Knowing the family of device belongs to helps with picking the ops
> > implementation which is appropriate to the device. So add a comment to
> > each structure of ops.
>
> This commit is not necessary. mv88e6xxx_ops structure must be per-chip,
> and the family information is already described in patch 03/11.
I disagree. I made a lot of errors adding the right per family handler
to these structures, simply because it is not obvious what family a
device belongs to when looking at the structure.
Andrew
next prev parent reply other threads:[~2016-11-14 2:49 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-11 2:53 [PATCH net-next 00/11] Start adding support for mv88e6390 family Andrew Lunn
2016-11-11 2:53 ` [PATCH net-next 01/11] net: dsa: mv88e6xxx: Take switch out of reset before probe Andrew Lunn
2016-11-14 1:23 ` Vivien Didelot
2016-11-11 2:53 ` [PATCH net-next 02/11] net: dsa: mv88e6xxx: Fix unused variable warning by using variable Andrew Lunn
2016-11-14 1:25 ` Vivien Didelot
2016-11-11 2:53 ` [PATCH net-next 03/11] net: dsa: mv88e6xxx: Add the mv88e6390 family Andrew Lunn
2016-11-14 2:05 ` Vivien Didelot
2016-11-11 2:53 ` [PATCH net-next 04/11] net: dsa: mv88e6xxx: Abstract stats_snapshot into ops structure Andrew Lunn
2016-11-13 23:37 ` Vivien Didelot
2016-11-11 2:53 ` [PATCH net-next 05/11] net: dsa: mv88e6xxx: Add comment about family a device belongs to Andrew Lunn
2016-11-14 2:08 ` Vivien Didelot
2016-11-14 2:48 ` Andrew Lunn [this message]
2016-11-11 2:53 ` [PATCH net-next 06/11] net: dsa: mv88e6xxx: Add mv88e6390 stats snapshot operation Andrew Lunn
2016-11-11 2:53 ` [PATCH net-next 07/11] net: dsa: mv88e6xxx: Add mv88e6390 statistics unit init Andrew Lunn
2016-11-14 2:29 ` Vivien Didelot
2016-11-11 2:53 ` [PATCH net-next 08/11] net: dsa: mv88e6xxx: Add stats_get_sset_count to ops structure Andrew Lunn
2016-11-14 2:47 ` Vivien Didelot
2016-11-11 2:53 ` [PATCH net-next 09/11] net: dsa: mv88e6xxx: Add stats_get_strings " Andrew Lunn
2016-11-11 2:53 ` [PATCH net-next 10/11] net: dsa: mv88e6xxx: Add stats_get_stats " Andrew Lunn
2016-11-11 2:53 ` [PATCH net-next 11/11] net: dsa: mv88e6xxx: Implement mv88e6390 get_stats Andrew Lunn
2016-11-13 5:48 ` [PATCH net-next 00/11] Start adding support for mv88e6390 family David Miller
2016-11-13 20:24 ` Andrew Lunn
2016-11-14 3:39 ` David Miller
2016-11-14 21:30 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161114024852.GA26710@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=vivien.didelot@savoirfairelinux.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.