From: Christoph Hellwig <hch@infradead.org>
To: NeilBrown <neilb@suse.com>
Cc: Christoph Hellwig <hch@infradead.org>,
Shaohua Li <shli@kernel.org>,
linux-raid@vger.kernel.org, linux-block@vger.kernel.org
Subject: Re: "creative" bio usage in the RAID code
Date: Mon, 14 Nov 2016 00:51:51 -0800 [thread overview]
Message-ID: <20161114085151.GA8405@infradead.org> (raw)
In-Reply-To: <87shqvj83r.fsf@notabene.neil.brown.name>
On Mon, Nov 14, 2016 at 10:03:20AM +1100, NeilBrown wrote:
> I would suggest adding a "bi_dev_private" field to the bio which is for
> use by the lowest-level driver (much as bi_private is for use by the
> top-level initiator).
> That could be in a union with any or all of:
> unsigned int bi_phys_segments;
> unsigned int bi_seg_front_size;
> unsigned int bi_seg_back_size;
>
> (any driver that needs those, would see a 'request' rather than a 'bio'
> and so could use rq->special)
>
> raid5.c could then use bi_dev_private (or bi_special, or whatever it is call).
All the three above fields are those that could go away with a full
implementation of the multipage bvec scheme. So any field for driver
use would still be be overhead. If it's just for raid5 it could
be a smaller 16 bit (or maybe even just 8 bit) one.
next prev parent reply other threads:[~2016-11-14 8:51 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-10 19:46 "creative" bio usage in the RAID code Christoph Hellwig
2016-11-11 19:02 ` Shaohua Li
2016-11-12 17:42 ` Christoph Hellwig
2016-11-13 22:53 ` NeilBrown
2016-11-13 22:53 ` NeilBrown
2016-11-14 8:57 ` Christoph Hellwig
2016-11-14 9:51 ` NeilBrown
2016-11-14 9:51 ` NeilBrown
2016-11-15 0:13 ` Shaohua Li
2016-11-15 1:30 ` Ming Lei
2016-11-15 1:30 ` Ming Lei
2016-11-13 23:03 ` NeilBrown
2016-11-14 8:51 ` Christoph Hellwig [this message]
2016-11-14 9:43 ` NeilBrown
2016-11-14 9:43 ` NeilBrown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161114085151.GA8405@infradead.org \
--to=hch@infradead.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=neilb@suse.com \
--cc=shli@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.