From: Chris Wilson <chris@chris-wilson.co.uk>
To: Petri Latvala <petri.latvala@intel.com>
Cc: daniel.vetter@ffwll.ch, intel-gfx@lists.freedesktop.org,
Nautiyal Ankit <ankit.k.nautiyal@intel.com>,
paulo.r.zanoni@intel.com, rodrigo.vivi@intel.com
Subject: Re: [PATCH v3] Idleness DRRS test
Date: Mon, 14 Nov 2016 13:06:09 +0000 [thread overview]
Message-ID: <20161114130609.GA32034@nuc-i3427.alporthouse.com> (raw)
In-Reply-To: <20161114124435.dgfyzuzng4t75knb@platvala-desk.ger.corp.intel.com>
On Mon, Nov 14, 2016 at 02:44:35PM +0200, Petri Latvala wrote:
> Chris, happy with this revision?
Me? No. It still uses a thread instead of events, so I don't think it
qualifies as a good example for anyone else wanting to do the same thing.
Lots of hardcoded expectations (specific sleep patterns, rather than
waiting for the kernel to change with a timeout for failure). It doesn't
check all the possible ways that the output maybe changed (and if they
are irrelevent, that too also needs to be tested to establish expected
behaviour and catch future regressions). Important question, how is
userspace expected to know that the vrefresh changed? How do get around
that userspace is expecting a fixed vblank frequency?
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2016-11-14 13:06 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-31 8:16 [RFC] Idleness DRRS test Nautiyal Ankit
2016-09-07 14:53 ` Marius Vlad
2016-09-23 12:07 ` Nautiyal, Ankit K
2016-09-23 12:40 ` [PATCH v2] " Nautiyal Ankit
2016-09-23 13:18 ` Chris Wilson
2016-09-27 11:19 ` Nautiyal, Ankit K
2016-10-21 3:52 ` [PATCH v3] " Nautiyal Ankit
2016-11-14 12:44 ` Petri Latvala
2016-11-14 13:06 ` Chris Wilson [this message]
2016-11-15 8:58 ` Daniel Vetter
2016-11-29 9:36 ` Nautiyal, Ankit K
2016-11-30 9:22 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161114130609.GA32034@nuc-i3427.alporthouse.com \
--to=chris@chris-wilson.co.uk \
--cc=ankit.k.nautiyal@intel.com \
--cc=daniel.vetter@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
--cc=paulo.r.zanoni@intel.com \
--cc=petri.latvala@intel.com \
--cc=rodrigo.vivi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.