From mboxrd@z Thu Jan 1 00:00:00 1970 From: maxime.ripard@free-electrons.com (Maxime Ripard) Date: Mon, 14 Nov 2016 14:10:46 +0100 Subject: [linux-sunxi] Re: [PATCH 3/3] ARM: dts: sunxi: add support for Orange Pi Zero board In-Reply-To: References: <20161111164654.15273-1-icenowy@aosc.xyz> <20161111164654.15273-3-icenowy@aosc.xyz> <20161114085839.qzu7ebeghoqlqygn@lukather> Message-ID: <20161114131046.t2iy3imx5ozcgrp6@lukather> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Mon, Nov 14, 2016 at 11:00:32AM +0100, Hans de Goede wrote: > > > > +&usbphy { > > > > + /* USB VBUS is always on */ > > > > > > You can put the always on regulators (I'm guessing reg_vcc5v0 ?) here. > > > > AFAIK the regulator properties are optional the the USB PHY. > > So we probably don't need to add it. Hans (CC-ed) could explain > > his original intent? > > I've made the regulators optional exactly for boards like these, > where there is no regulator. Likely the Vbus is simply wired > directly to the 5V DC-in jack. So IMHO adding something like > the fixed reg_vcc5v0 a supply here just makes the dt > harder to read. It also makes the regulator tree more complete and accurate because you'd list all the devices that are needing those regulators. That would also make it easier to deal with in the future. But fair enough. Maxime -- Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 801 bytes Desc: not available URL: From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maxime Ripard Subject: Re: Re: [PATCH 3/3] ARM: dts: sunxi: add support for Orange Pi Zero board Date: Mon, 14 Nov 2016 14:10:46 +0100 Message-ID: <20161114131046.t2iy3imx5ozcgrp6@lukather> References: <20161111164654.15273-1-icenowy@aosc.xyz> <20161111164654.15273-3-icenowy@aosc.xyz> <20161114085839.qzu7ebeghoqlqygn@lukather> Reply-To: maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="rddduspccowvqz4q" Return-path: Sender: linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org Content-Disposition: inline In-Reply-To: List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , To: Hans de Goede Cc: Chen-Yu Tsai , Icenowy Zheng , Jonathan Corbet , Rob Herring , Mark Rutland , Russell King , "linux-doc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , linux-arm-kernel , linux-kernel , devicetree , linux-sunxi List-Id: devicetree@vger.kernel.org --rddduspccowvqz4q Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline On Mon, Nov 14, 2016 at 11:00:32AM +0100, Hans de Goede wrote: > > > > +&usbphy { > > > > + /* USB VBUS is always on */ > > > > > > You can put the always on regulators (I'm guessing reg_vcc5v0 ?) here. > > > > AFAIK the regulator properties are optional the the USB PHY. > > So we probably don't need to add it. Hans (CC-ed) could explain > > his original intent? > > I've made the regulators optional exactly for boards like these, > where there is no regulator. Likely the Vbus is simply wired > directly to the 5V DC-in jack. So IMHO adding something like > the fixed reg_vcc5v0 a supply here just makes the dt > harder to read. It also makes the regulator tree more complete and accurate because you'd list all the devices that are needing those regulators. That would also make it easier to deal with in the future. But fair enough. Maxime -- Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com --rddduspccowvqz4q-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753240AbcKNNUh (ORCPT ); Mon, 14 Nov 2016 08:20:37 -0500 Received: from mail.free-electrons.com ([62.4.15.54]:41153 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750998AbcKNNUe (ORCPT ); Mon, 14 Nov 2016 08:20:34 -0500 Date: Mon, 14 Nov 2016 14:10:46 +0100 From: Maxime Ripard To: Hans de Goede Cc: Chen-Yu Tsai , Icenowy Zheng , Jonathan Corbet , Rob Herring , Mark Rutland , Russell King , "linux-doc@vger.kernel.org" , linux-arm-kernel , linux-kernel , devicetree , linux-sunxi Subject: Re: [linux-sunxi] Re: [PATCH 3/3] ARM: dts: sunxi: add support for Orange Pi Zero board Message-ID: <20161114131046.t2iy3imx5ozcgrp6@lukather> References: <20161111164654.15273-1-icenowy@aosc.xyz> <20161111164654.15273-3-icenowy@aosc.xyz> <20161114085839.qzu7ebeghoqlqygn@lukather> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="rddduspccowvqz4q" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.6.2-neo (2016-08-21) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --rddduspccowvqz4q Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Nov 14, 2016 at 11:00:32AM +0100, Hans de Goede wrote: > > > > +&usbphy { > > > > + /* USB VBUS is always on */ > > >=20 > > > You can put the always on regulators (I'm guessing reg_vcc5v0 ?) here. > >=20 > > AFAIK the regulator properties are optional the the USB PHY. > > So we probably don't need to add it. Hans (CC-ed) could explain > > his original intent? >=20 > I've made the regulators optional exactly for boards like these, > where there is no regulator. Likely the Vbus is simply wired > directly to the 5V DC-in jack. So IMHO adding something like > the fixed reg_vcc5v0 a supply here just makes the dt > harder to read. It also makes the regulator tree more complete and accurate because you'd list all the devices that are needing those regulators. That would also make it easier to deal with in the future. But fair enough. Maxime --=20 Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com --rddduspccowvqz4q Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIcBAEBCAAGBQJYKbfSAAoJEBx+YmzsjxAg0oAP+wWBItEVV7A8wPS7IFQvNXr1 kMJ4//CBWGnWOQo4EwdjbxgmCph+Rtfh9sSJ2NXFtnRnu8sp72lFBg5VDlVgWBcw QurSJEofThx3T11uJlaIe4DMbcitpJ/we+3tMLKvcHGwCyiWxECgnFobvzb5efsI QOcMc2X9cQKckSW/VUVNxof4dcFUQlaU1TM3J/Jn/qbq97sCbXtSMT/wG6c6y3Wi FzA30TT3S8OE+kl+J4uo0Jk1EdIVozLnHXFUMjk80P+6YsmrIX4WEDMgOliJD9xL C6Zj8/duCSS8/pqoTZ3+5JbRL/5vhujUkY8PRaV7l6/iWRcZepDKjQE9QxyML9AG wzjt028qybP2N2I+tWUg/g5GJ47J6q+JKsjdJU7/9sJrWOgWQ4pRa2B0v2kf7YyK rTSOqAP3u9QxSJGD6KBdEebyaaCIDyHbRIHYH8qPtWZ9/nwNVyG8b4Tuf0/WcD+/ AX0Ya9p332gnwUPiWXIB1p88g/VQr2GXnwJel5iIiWbNlZsGeGXdoNZp0PFxhhEs +w6frO0xymf8Fy4vFkEw3CXec7AvQGFDphmiG1u97dtABQFtB0ovoMATbvjpDxVZ tkVI77rfXpVa+vCPYVFMdeWjRokDXFc/jF1ZaRC/JU3/DsjcrU87VZ4Ri7ZcNZbz N8V9EIwfP4atUdtGFO+Q =2ut4 -----END PGP SIGNATURE----- --rddduspccowvqz4q--