From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maxime Ripard Date: Mon, 14 Nov 2016 15:12:37 +0100 Subject: [U-Boot] [PATCH 3/7] sunxi: Enable UBI and NAND support In-Reply-To: <49cb76e1-cd3c-c912-8acf-74e98377f199@redhat.com> References: <6c44b7aa93af6ffd76d4d0bee5713f087e082c62.1478621974.git-series.maxime.ripard@free-electrons.com> <49cb76e1-cd3c-c912-8acf-74e98377f199@redhat.com> Message-ID: <20161114141237.pbvskuy76zbyv2iz@lukather> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Mon, Nov 14, 2016 at 12:18:06PM +0100, Hans de Goede wrote: > > #ifdef CONFIG_SPL_SPI_SUNXI > > @@ -143,7 +157,14 @@ > > #define CONFIG_GENERIC_MMC > > #define CONFIG_MMC_SUNXI > > #define CONFIG_MMC_SUNXI_SLOT 0 > > -#define CONFIG_ENV_IS_IN_MMC > > +#endif > > + > > +#if defined(CONFIG_ENV_IS_IN_NAND) > > +#define CONFIG_ENV_OFFSET 0xc00000 > > +#define CONFIG_ENV_SIZE 0x400000 > > +#elif defined(CONFIG_ENV_IS_IN_MMC) > > +#define CONFIG_ENV_OFFSET (544 << 10) /* (8 + 24 + 512) KiB */ > > +#define CONFIG_ENV_SIZE (128 << 10) /* 128 KiB */ > > #define CONFIG_SYS_MMC_ENV_DEV 0 /* first detected MMC controller */ > > #endif Oh, and this part is broken. It relies on the fact that all board define ENV_IS_IN_MMC (which they should), while obviously they don't. I'm not exactly sure about what the proper fix would be. Maxime -- Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 801 bytes Desc: not available URL: