From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out4-smtp.messagingengine.com ([66.111.4.28]:39402 "EHLO out4-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751134AbcKNOM7 (ORCPT ); Mon, 14 Nov 2016 09:12:59 -0500 Date: Mon, 14 Nov 2016 15:13:10 +0100 From: Greg KH To: Peter Chen Cc: linux-usb@vger.kernel.org, "#v4 . 1+" Subject: Re: [PATCH 1/1] usb: chipidea: move the lock initialization to core file Message-ID: <20161114141310.GB21395@kroah.com> References: <1477878940-24719-1-git-send-email-peter.chen@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1477878940-24719-1-git-send-email-peter.chen@nxp.com> Sender: stable-owner@vger.kernel.org List-ID: On Mon, Oct 31, 2016 at 09:55:40AM +0800, Peter Chen wrote: > This can fix below dump when the lock is accessed at host > mode due to it is not initialized. > > root@imx6qdlsolo:~# cat /sys/kernel/debug/ci_hdrc.1/port_test > [ 929.904518] INFO: trying to register non-static key. > [ 929.909536] the code is fine but needs lockdep annotation. > [ 929.915043] turning off the locking correctness validator. > [ 929.920567] CPU: 0 PID: 687 Comm: cat Not tainted 4.9.0-rc1-00064-g903de10 #1155 > [ 929.927987] Hardware name: Freescale i.MX6 Ultralite (Device Tree) > [ 929.934189] Backtrace: > [ 929.936719] [] (dump_backtrace) from [] (show_stack+0x18/0x1c) > [ 929.944312] r7:de47a000[ 929.946690] r6:60000193 > r5:00000000[ 929.950322] r4:c0e2346c > [ 929.952883] > [ 929.954413] [] (show_stack) from [] (dump_stack+0xb4/0xe8) > [ 929.961675] [] (dump_stack) from [] (register_lock_class+0x4fc/0x56c) > [ 929.969871] r10:c0e23564[ 929.972335] r9:de47be70 > r8:c163f444[ 929.975967] r7:ddcd4024 > r6:00000000[ 929.979598] r5:00000000 > [ 929.982158] r4:00000000[ 929.984534] r3:00000001 > [ 929.987092] > [ 929.988622] [] (register_lock_class) from [] (__lock_acquire+0x80/0x10f0) > [ 929.997166] r10:c0e23564[ 929.999632] r9:de47be70 > r8:ddcd4024[ 930.003265] r7:c163f444 > r6:ddec3c00[ 930.006898] r5:60000193 > [ 930.009458] r4:00000000[ 930.011832] > [ 930.013368] [] (__lock_acquire) from [] (lock_acquire+0x74/0x94) > [ 930.021129] r10:00000001[ 930.023594] r9:de47be70 > r8:de47bf80[ 930.027225] r7:00000001 > r6:00000001[ 930.030857] r5:60000193 > [ 930.033417] r4:00000000[ 930.035791] > [ 930.037329] [] (lock_acquire) from [] (_raw_spin_lock_irqsave+0x40/0x54) > [ 930.045787] r7:dddb3c80[ 930.048163] r6:c062a468 > r5:20000113[ 930.051795] r4:ddcd4014 > [ 930.054354] > [ 930.055885] [] (_raw_spin_lock_irqsave) from [] (ci_port_test_show+0x2c/0x70) > [ 930.064776] r6:ddd930c0[ 930.067153] r5:ddcd4010 > r4:ddcd4014[ 930.070783] > [ 930.072329] [] (ci_port_test_show) from [] (seq_read+0x1ac/0x4f8) > [ 930.080179] r9:de47be70[ 930.082555] r8:de47bf80 > r7:dddb3c80[ 930.086188] r6:00000001 > r5:00000000[ 930.089820] r4:ddd930c0 > [ 930.092404] [] (seq_read) from [] (full_proxy_read+0x54/0x6c) > [ 930.099907] r10:00000000[ 930.102372] r9:c0a6ad70 > r8:de47bf80[ 930.106004] r7:00020000 > r6:b6dd1000[ 930.109636] r5:dddb3c80 > [ 930.112197] r4:c0248ed8[ 930.114572] > [ 930.116110] [] (full_proxy_read) from [] (__vfs_read+0x34/0x118) > [ 930.123872] r9:de47a000[ 930.126250] r8:c0107fc4 > r7:00020000[ 930.129883] r6:de47bf80 > r5:c039eb88[ 930.133515] r4:dddb3c80 > [ 930.136091] [] (__vfs_read) from [] (vfs_read+0x8c/0x11c) > [ 930.143247] r9:de47a000[ 930.145625] r8:c0107fc4 > r7:de47bf80[ 930.149259] r6:b6dd1000 > r5:dddb3c80[ 930.152891] r4:00020000 > [ 930.155469] [] (vfs_read) from [] (SyS_read+0x4c/0xa8) > [ 930.162363] r8:c0107fc4[ 930.164741] r7:00020000 > r6:b6dd1000[ 930.168373] r5:dddb3c80 > r4:dddb3c80[ 930.172001] > [ 930.173540] [] (SyS_read) from [] (ret_fast_syscall+0x0/0x1c) > [ 930.181041] r7:00000003[ 930.183419] r6:b6dd1000 > r5:00020000[ 930.187051] r4:00020000 > [ 930.189611] > mode = 0 Clean up the dump please :(