From: Peter Zijlstra <peterz@infradead.org>
To: Jacob Pan <jacob.jun.pan@linux.intel.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
Linux PM <linux-pm@vger.kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Zhang Rui <rui.zhang@intel.com>,
Rafael Wysocki <rafael.j.wysocki@intel.com>,
"Chen, Yu C" <yu.c.chen@intel.com>,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
Petr Mladek <pmladek@suse.com>,
Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
Arjan van de Ven <arjan@linux.intel.com>
Subject: Re: [PATCH 2/3] cpuidle: allow setting deepest idle
Date: Mon, 14 Nov 2016 15:58:01 +0100 [thread overview]
Message-ID: <20161114145801.GF3142@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <1478718312-12847-3-git-send-email-jacob.jun.pan@linux.intel.com>
On Wed, Nov 09, 2016 at 11:05:11AM -0800, Jacob Pan wrote:
> --- a/kernel/sched/idle.c
> +++ b/kernel/sched/idle.c
> @@ -173,6 +173,9 @@ static void cpuidle_idle_call(void)
>
> next_state = cpuidle_find_deepest_state(drv, dev);
> call_cpuidle(drv, dev, next_state);
> + } else if (dev->use_deepest_state) {
> + next_state = cpuidle_find_deepest_state(drv, dev);
> + call_cpuidle(drv, dev, next_state);
looks like excessive indenting..
> } else {
> /*
> * Ask the cpuidle framework to choose a convenient idle state.
> --
> 1.9.1
>
next prev parent reply other threads:[~2016-11-14 14:58 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-09 19:05 [PATCH 0/3] Stop sched tick in idle injection task Jacob Pan
2016-11-09 19:05 ` [PATCH 1/3] idle: add support for tasks that inject idle Jacob Pan
2016-11-14 14:57 ` Peter Zijlstra
2016-11-14 15:01 ` Peter Zijlstra
2016-11-14 15:01 ` Peter Zijlstra
2016-11-14 16:20 ` Jacob Pan
2016-11-14 16:22 ` Peter Zijlstra
2016-11-14 16:29 ` Jacob Pan
2016-11-09 19:05 ` [PATCH 2/3] cpuidle: allow setting deepest idle Jacob Pan
2016-11-14 14:58 ` Peter Zijlstra [this message]
2016-11-09 19:05 ` [PATCH 3/3] thermal/powerclamp: use PF_IDLE in injection kthread Jacob Pan
2016-11-14 15:11 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161114145801.GF3142@twins.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=arjan@linux.intel.com \
--cc=bigeasy@linutronix.de \
--cc=jacob.jun.pan@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=pmladek@suse.com \
--cc=rafael.j.wysocki@intel.com \
--cc=rui.zhang@intel.com \
--cc=srinivas.pandruvada@linux.intel.com \
--cc=tglx@linutronix.de \
--cc=yu.c.chen@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.