From mboxrd@z Thu Jan 1 00:00:00 1970 From: Peter Zijlstra Subject: Re: [PATCH 1/3] idle: add support for tasks that inject idle Date: Mon, 14 Nov 2016 16:01:19 +0100 Message-ID: <20161114150119.GG3142@twins.programming.kicks-ass.net> References: <1478718312-12847-1-git-send-email-jacob.jun.pan@linux.intel.com> <1478718312-12847-2-git-send-email-jacob.jun.pan@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1478718312-12847-2-git-send-email-jacob.jun.pan@linux.intel.com> Sender: linux-kernel-owner@vger.kernel.org To: Jacob Pan Cc: LKML , Linux PM , Thomas Gleixner , Ingo Molnar , Zhang Rui , Rafael Wysocki , "Chen, Yu C" , Sebastian Andrzej Siewior , Petr Mladek , Srinivas Pandruvada , Arjan van de Ven List-Id: linux-pm@vger.kernel.org On Wed, Nov 09, 2016 at 11:05:10AM -0800, Jacob Pan wrote: > +void play_idle() > +{ > + /* > + * Only FIFO tasks can disable the tick since they don't need the forced > + * preemption. > + */ > + WARN_ON_ONCE(current->policy != SCHED_FIFO); > + WARN_ON_ONCE(current->nr_cpus_allowed != 1); > + WARN_ON_ONCE(!(current->flags & PF_KTHREAD)); > + WARN_ON_ONCE(!(current->flags & PF_NO_SETAFFINITY)); > + rcu_sleep_check(); > + > + preempt_disable(); > + current->flags |= PF_IDLE; > + do_idle(); > + current->flags &= ~PF_IDLE; > + > + preempt_fold_need_resched(); > + preempt_enable(); > +} > +EXPORT_SYMBOL_GPL(play_idle); Hurm.. didn't this initially also include the setup of the timer and take an timeout argument?