From: Lee Jones <lee.jones@linaro.org>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Quentin Schulz <quentin.schulz@free-electrons.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mfd: sun4i-gpadc: select regmap-irq
Date: Mon, 14 Nov 2016 17:40:10 +0000 [thread overview]
Message-ID: <20161114174010.GA4094@dell> (raw)
In-Reply-To: <20161031153246.3561667-1-arnd@arndb.de>
On Mon, 31 Oct 2016, Arnd Bergmann wrote:
> The new sun4i mfd driver is lacking a dependency, triggering very rarely
> int randconfig kernel builds:
>
> drivers/mfd/sun4i-gpadc.o: In function `sun4i_gpadc_probe':
> sun4i-gpadc.c:(.text.sun4i_gpadc_probe+0x110): undefined reference to `devm_regmap_add_irq_chip'
>
> This adds a 'select REGMAP_IRQ', as the other drivers with this problem do.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/mfd/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
Applied, thanks.
> diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
> index 30978295a1e8..3a4c43df9404 100644
> --- a/drivers/mfd/Kconfig
> +++ b/drivers/mfd/Kconfig
> @@ -44,6 +44,7 @@ config MFD_SUN4I_GPADC
> tristate "Allwinner sunxi platforms' GPADC MFD driver"
> select MFD_CORE
> select REGMAP_MMIO
> + select REGMAP_IRQ
> depends on ARCH_SUNXI || COMPILE_TEST
> help
> Select this to get support for Allwinner SoCs (A10, A13 and A31) ADC.
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
prev parent reply other threads:[~2016-11-14 17:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-31 15:31 [PATCH] mfd: sun4i-gpadc: select regmap-irq Arnd Bergmann
2016-11-14 17:40 ` Lee Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161114174010.GA4094@dell \
--to=lee.jones@linaro.org \
--cc=arnd@arndb.de \
--cc=linux-kernel@vger.kernel.org \
--cc=quentin.schulz@free-electrons.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.