All of lore.kernel.org
 help / color / mirror / Atom feed
From: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Jeff Layton <jlayton@redhat.com>,
	Sparse Mailing-list <linux-sparse@vger.kernel.org>,
	Al Viro <viro@ftp.linux.org.uk>
Subject: Re: [PATCH] Handle SForced in storage_modifiers
Date: Mon, 14 Nov 2016 21:21:46 +0100	[thread overview]
Message-ID: <20161114202145.GB15866@macbook.local> (raw)
In-Reply-To: <CA+55aFxbn+ZAyN9zzcEF60UPoRN2hq86LHk9v5ecqg-c+x3pNw@mail.gmail.com>

On Mon, Nov 14, 2016 at 12:17:47PM -0800, Linus Torvalds wrote:
> On Mon, Nov 14, 2016 at 12:04 PM, Luc Van Oostenryck
> <luc.vanoostenryck@gmail.com> wrote:
> >
> > The array is statically initialized and never modified,
> > your patch shouldn't change anything, and this regardless of
> > the memory layout or compiler options.
> 
> The problem is the _size_ of the array. Without that initializer for
> SForced case, it is one entry too small, and you get a random access
> past the end of the array.
> 
> The patch is definitely correct.
> 
>               Linus
> --

Ah yes, indeed.

Thanks

  reply	other threads:[~2016-11-14 20:21 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-14 19:12 [PATCH] Handle SForced in storage_modifiers Jeff Layton
2016-11-14 20:04 ` Luc Van Oostenryck
2016-11-14 20:17   ` Linus Torvalds
2016-11-14 20:21     ` Luc Van Oostenryck [this message]
2016-11-15  1:00     ` Christopher Li
2016-11-15  2:07       ` Jeff Layton
2016-11-16 22:28         ` Christopher Li
2016-11-17 12:43           ` Jeff Layton
2017-01-05  6:39           ` Luc Van Oostenryck
2016-11-15  4:30       ` Josh Triplett

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161114202145.GB15866@macbook.local \
    --to=luc.vanoostenryck@gmail.com \
    --cc=jlayton@redhat.com \
    --cc=linux-sparse@vger.kernel.org \
    --cc=torvalds@linux-foundation.org \
    --cc=viro@ftp.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.