From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755556AbcKOHsX (ORCPT ); Tue, 15 Nov 2016 02:48:23 -0500 Received: from bombadil.infradead.org ([198.137.202.9]:42997 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752852AbcKOHsW (ORCPT ); Tue, 15 Nov 2016 02:48:22 -0500 Date: Tue, 15 Nov 2016 08:48:18 +0100 From: Peter Zijlstra To: Greg KH Cc: keescook@chromium.org, will.deacon@arm.com, elena.reshetova@intel.com, arnd@arndb.de, tglx@linutronix.de, mingo@kernel.org, hpa@zytor.com, dave@progbits.org, linux-kernel@vger.kernel.org Subject: Re: [RFC][PATCH 0/7] kref improvements Message-ID: <20161115074818.GL3142@twins.programming.kicks-ass.net> References: <20161114173946.501528675@infradead.org> <20161115072742.GA28248@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20161115072742.GA28248@kroah.com> User-Agent: Mutt/1.5.23.1 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Nov 15, 2016 at 08:27:42AM +0100, Greg KH wrote: > On Mon, Nov 14, 2016 at 06:39:46PM +0100, Peter Zijlstra wrote: > > This series unfscks kref and then implements it in terms of refcount_t. > > > > x86_64-allyesconfig compile tested and boot tested with my regular config. > > > > refcount_t is as per the previous thread, it BUGs on over-/underflow and > > saturates at UINT_MAX, such that if we ever overflow, we'll never free again. > > > > > > Thanks so much for doing these, at the very least, I want to take the > kref-abuse-fixes now as those users shouldn't be doing those foolish > things. Any objection for me taking some of them through my tree now? None at all, but please double check at least the 'kill kref_sub()' one, I might have messed up drbd or something, that code isn't entirely transparant.