All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Shiva Kerdel <shiva@exdev.nl>
Cc: stuart.yoder@nxp.com, German.Rivera@freescale.com,
	treding@nvidia.com, itai.katz@nxp.com,
	linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org
Subject: Re: [PATCH][RESPIN] Staging: fsl-mc: include: mc: Kernel type 'int' preferred over 's16'
Date: Tue, 15 Nov 2016 11:02:17 +0100	[thread overview]
Message-ID: <20161115100217.GA19614@kroah.com> (raw)
In-Reply-To: <20161115083003.6017-1-shiva@exdev.nl>

On Tue, Nov 15, 2016 at 09:30:03AM +0100, Shiva Kerdel wrote:
> After following a discussion about the used integer types Dan Carpenter
> pointed out that 'int' types should be used over the current change to
> 's16'. The reason for this is to have an upper bound instead of overflowing
> the 's16' so we could still remove devices.
> 
> Signed-off-by: Shiva Kerdel <shiva@exdev.nl>
> Suggested-by: Stuart Yoder <stuart.yoder@nxp.com>
> Suggested-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
>  drivers/staging/fsl-mc/include/mc-bus.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

In the future, don't do [RESPIN] as that means nothing to me, and is
just noise...

thanks,

greg k-h

      reply	other threads:[~2016-11-15 10:02 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-15  8:30 [PATCH][RESPIN] Staging: fsl-mc: include: mc: Kernel type 'int' preferred over 's16' Shiva Kerdel
2016-11-15 10:02 ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161115100217.GA19614@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=German.Rivera@freescale.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=itai.katz@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=shiva@exdev.nl \
    --cc=stuart.yoder@nxp.com \
    --cc=treding@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.