All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2] htop: enable unicode if possible
Date: Tue, 15 Nov 2016 13:03:28 +0100	[thread overview]
Message-ID: <20161115130328.42a20c5e@free-electrons.com> (raw)
In-Reply-To: <20161114110448.9162-1-jezz@sysmic.org>

Hello,

On Mon, 14 Nov 2016 12:04:48 +0100, J?r?me Pouiller wrote:

> +ifeq ($(BR2_PACKAGE_NCURSES_WCHAR),)

You should have used positive logic instead:

ifeq ($(BR2_PACKAGE_NCURSES_WCHAR),y)
enable feature
else
disable feature
endif

> +HTOP_CONF_OPTS = --disable-unicode

You should use += here instead of =, since we are in a condition. This
helps avoiding stupid bugs in the future, if additional CONF_OPTS
assignments are added earlier in the file.

Applied to next with those two issues fixed.

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

      reply	other threads:[~2016-11-15 12:03 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-14 11:04 [Buildroot] [PATCH v2] htop: enable unicode if possible Jérôme Pouiller
2016-11-15 12:03 ` Thomas Petazzoni [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161115130328.42a20c5e@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.