From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Tue, 15 Nov 2016 14:49:32 +0100 From: Christoph Hellwig To: Jens Axboe Cc: Omar Sandoval , axboe@kernel.dk, linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, hch@infradead.org, Christoph Hellwig Subject: Re: [PATCH 1/3] block: fast-path for small and simple direct I/O requests Message-ID: <20161115134932.GA28632@lst.de> References: <1478927487-12998-1-git-send-email-axboe@fb.com> <1478927487-12998-2-git-send-email-axboe@fb.com> <20161114193339.GA31821@vader.DHCP.thefacebook.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: List-ID: On Mon, Nov 14, 2016 at 01:00:09PM -0700, Jens Axboe wrote: > Prefetches like that tend to grow stale, in my experience. So we should > probably just evaluate the new path cache behavior and see if it makes > sense. Yes. I've tested the patches with that in place, but it didn't make a difference. Probably because we're not wasting many cycles between the possible place for the prefetch and the use of it anyway.