From: Jiri Benc <jbenc@redhat.com>
To: Pravin B Shelar <pshelar@ovn.org>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH net-next v3 4/7] vxlan: improve vxlan route lookup checks.
Date: Tue, 15 Nov 2016 15:39:34 +0100 [thread overview]
Message-ID: <20161115153934.363e176d@griffin> (raw)
In-Reply-To: <1479098638-4921-5-git-send-email-pshelar@ovn.org>
On Sun, 13 Nov 2016 20:43:55 -0800, Pravin B Shelar wrote:
> @@ -1929,8 +1951,8 @@ static void vxlan_xmit_one(struct sk_buff *skb, struct net_device *dev,
> union vxlan_addr *src;
> struct vxlan_metadata _md;
> struct vxlan_metadata *md = &_md;
> - struct dst_entry *ndst = NULL;
> __be16 src_port = 0, dst_port;
> + struct dst_entry *ndst = NULL;
> __be32 vni, label;
> __be16 df = 0;
> __u8 tos, ttl;
This looks kind of arbitrary. You might want to remove this hunk or
merge it to patch 3.
Other than that,
Acked-by: Jiri Benc <jbenc@redhat.com>
next prev parent reply other threads:[~2016-11-15 14:39 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-14 4:43 [PATCH net-next v3 0/7] vxlan: xmit improvements Pravin B Shelar
2016-11-14 4:43 ` [PATCH net-next v3 1/7] vxlan: avoid vlan processing in vxlan device Pravin B Shelar
2016-11-14 4:43 ` [PATCH net-next v3 2/7] vxlan: avoid checking socket multiple times Pravin B Shelar
2016-11-15 14:15 ` Jiri Benc
2016-11-14 4:43 ` [PATCH net-next v3 3/7] vxlan: simplify exception handling Pravin B Shelar
2016-11-15 14:30 ` Jiri Benc
2016-11-15 16:40 ` Pravin Shelar
2016-11-15 17:04 ` Jiri Benc
2016-11-15 17:15 ` Pravin Shelar
2016-11-14 4:43 ` [PATCH net-next v3 4/7] vxlan: improve vxlan route lookup checks Pravin B Shelar
2016-11-15 14:39 ` Jiri Benc [this message]
2016-11-17 10:17 ` David Laight
2016-11-17 15:59 ` Jiri Benc
2016-11-17 18:11 ` David Miller
2016-11-21 20:34 ` Pravin Shelar
2016-11-18 5:30 ` Pravin Shelar
2016-11-14 4:43 ` [PATCH net-next v3 5/7] vxlan: simplify RTF_LOCAL handling Pravin B Shelar
2016-11-15 14:44 ` Jiri Benc
2016-11-14 4:43 ` [PATCH net-next v3 6/7] vxlan: simplify vxlan xmit Pravin B Shelar
2016-11-14 4:43 ` [PATCH net-next v3 7/7] vxlan: remove unsed vxlan_dev_dst_port() Pravin B Shelar
2016-11-15 14:56 ` Jiri Benc
2016-11-15 17:16 ` [PATCH net-next v3 0/7] vxlan: xmit improvements David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161115153934.363e176d@griffin \
--to=jbenc@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=pshelar@ovn.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.