All of lore.kernel.org
 help / color / mirror / Atom feed
From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH 1/1] Tiny doc fixes
Date: Tue, 15 Nov 2016 17:50:41 +0100	[thread overview]
Message-ID: <20161115165040.GF24751@rei.lan> (raw)
In-Reply-To: <20161115164633.qromjokaqfw57jxr@dell5510>

Hi!
> > >  static struct tst_test test = {
> > >  	.tid = "getenv01",
> > > -	.test_all = test,
> > > +	.test_all = do_test,
> > >  	.setup = setup,
> > >  };
> 
> > What is wrong with this one?
> Name collision (function test and struct test). I know, it's just a doc...

Ah, right. I guess that we should to fix the example code to compile
cleanly.

> > And even if we decide to change the function name, we should fix it in
> > the text as well:
> 
> > -The test itself is done in the 'test()' function. The test function must work
> > +The test itself is done in the 'do_test()' function. The test function must work
> Sorry, it seems I can't do search and replace :-(.

Well the word test is used in the document so often that you have to
actually read the paragraph to figure out what needs to be updated.

-- 
Cyril Hrubis
chrubis@suse.cz

      reply	other threads:[~2016-11-15 16:50 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-15 10:06 [LTP] [PATCH 1/1] Tiny doc fixes Petr Vorel
2016-11-15 16:20 ` Cyril Hrubis
2016-11-15 16:46   ` Petr Vorel
2016-11-15 16:50     ` Cyril Hrubis [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161115165040.GF24751@rei.lan \
    --to=chrubis@suse.cz \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.