From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:39616)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1c6lmX-0006RB-2k
	for qemu-devel@nongnu.org; Tue, 15 Nov 2016 17:00:45 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1c6lmS-0003Qp-9e
	for qemu-devel@nongnu.org; Tue, 15 Nov 2016 17:00:45 -0500
Date: Wed, 16 Nov 2016 00:00:37 +0200
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20161115232243-mutt-send-email-mst@kernel.org>
References: <1479237527-11846-1-git-send-email-mst@redhat.com>
	<1479237527-11846-27-git-send-email-mst@redhat.com>
	<20161115213534.09a8145d@bahia>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20161115213534.09a8145d@bahia>
Subject: Re: [Qemu-devel] [PULL v3 26/28] vhost: drop legacy vring layout
 bits
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Greg Kurz <groug@kaod.org>
Cc: qemu-devel@nongnu.org, Cornelia Huck <cornelia.huck@de.ibm.com>, Peter Maydell <peter.maydell@linaro.org>, qemu-stable@nongnu.org

On Tue, Nov 15, 2016 at 09:35:34PM +0100, Greg Kurz wrote:
> On Tue, 15 Nov 2016 21:22:31 +0200
> "Michael S. Tsirkin" <mst@redhat.com> wrote:
> 
> > From: Greg Kurz <groug@kaod.org>
> > 
> > The legacy vring layout is not used anymore as we use the separate
> > mappings even for legacy devices.
> > This patch simply removes it.
> > 
> > This also fixes a bug with virtio 1 devices when the vring descriptor table
> > is mapped at a higher address than the used vring because the following
> > function may return an insanely great value:
> > 
> > hwaddr virtio_queue_get_ring_size(VirtIODevice *vdev, int n)
> > {
> >     return vdev->vq[n].vring.used - vdev->vq[n].vring.desc +
> >            virtio_queue_get_used_size(vdev, n);
> > }
> > 
> > and the mapping fails.
> > 
> 
> Michael,
> 
> I see the "vhost: adapt vhost_verify_ring_mappings() to virtio  1 ring layout"
> patch got Cc'ed to stable... any reason for not doing the same with this patch
> since it fixes the bug which motivated the whole series ?
> 
> Cheers.
> 
> --
> Greg

Not really, I just forgot. Pls go ahead and CC stable.

-- 
MST