All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] xmlstarlet: fix static linking problem
Date: Tue, 15 Nov 2016 23:58:01 +0100	[thread overview]
Message-ID: <20161115235801.2c6a74b1@free-electrons.com> (raw)
In-Reply-To: <20161107181429.GA23343@waldemar-brodkorb.de>

Hello,

On Mon, 7 Nov 2016 19:14:29 +0100, Waldemar Brodkorb wrote:
> Instead of patching configure.ac we can just add the missing
> libraries to LIBS. Tested with m68k/arm static builds.
> This makes the patch obsolete and the autoreconf can be avoided.
> 
> Fixes:
>   http://autobuild.buildroot.net/results/02f9fc5884d3a7d460b96937183362d6c3fc6fde
> 
> Signed-off-by: Waldemar Brodkorb <wbx@openadk.org>
> ---
>  ...Fix-static-linking-problem-with-libgcrypt.patch | 46 ----------------------
>  package/xmlstarlet/xmlstarlet.mk                   |  4 +-
>  2 files changed, 1 insertion(+), 49 deletions(-)
>  delete mode 100644 package/xmlstarlet/0001-Fix-static-linking-problem-with-libgcrypt.patch

I've applied to master, thanks. However, it's worth mentioning that:

 1. My patch had in fact been merged upstream
 (https://sourceforge.net/p/xmlstar/code/ci/0380e4d1e2d02aec868b7199e71bbe56e8161223/)
 even if I agree it's by far not the best solution.

 2. The proper solution would be to improve the configure.ac script to
 use pkg-config directly. But since upstream is not very active, and
 hasn't done a release since 2014, I can understand that you may not
 been very motivated to do this work.

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

      reply	other threads:[~2016-11-15 22:58 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-07 18:14 [Buildroot] [PATCH] xmlstarlet: fix static linking problem Waldemar Brodkorb
2016-11-15 22:58 ` Thomas Petazzoni [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161115235801.2c6a74b1@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.