All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
To: bskeggs-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org
Cc: nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
Subject: [bug report] drm/nouveau/kms/nv50: initial support for DP 1.2 multi-stream
Date: Wed, 16 Nov 2016 14:29:59 +0300	[thread overview]
Message-ID: <20161116112959.GA28421@mwanda> (raw)

Hello Ben Skeggs,

The patch f479c0ba4a17: "drm/nouveau/kms/nv50: initial support for DP
1.2 multi-stream" from Nov 4, 2016, leads to the following static
checker warning:

	drivers/gpu/drm/nouveau/nv50_display.c:3158 nv50_mstc_new()
	warn: this array is probably non-NULL. 'mstm->msto'

drivers/gpu/drm/nouveau/nv50_display.c
  3155          mstc->connector.funcs->reset(&mstc->connector);
  3156          nouveau_conn_attach_properties(&mstc->connector);
  3157  
  3158          for (i = 0; i < ARRAY_SIZE(mstm->msto) && mstm->msto; i++)
                                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
This doesn't make sense.  Maybe mstm->msto[i] was intended??

  3159                  drm_mode_connector_attach_encoder(&mstc->connector, &mstm->msto[i]->encoder);
  3160  
  3161          drm_object_attach_property(&mstc->connector.base, dev->mode_config.path_property, 0);
  3162          drm_object_attach_property(&mstc->connector.base, dev->mode_config.tile_property, 0);
  3163          drm_mode_connector_set_path_property(&mstc->connector, path);
  3164          return 0;

regards,
dan carpenter
_______________________________________________
Nouveau mailing list
Nouveau@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/nouveau

                 reply	other threads:[~2016-11-16 11:29 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161116112959.GA28421@mwanda \
    --to=dan.carpenter-qhclzuegtsvqt0dzr+alfa@public.gmane.org \
    --cc=bskeggs-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    --cc=nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.